Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-117995: Don't raise DeprecationWarnings for indexed nameless params#118001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedApr 17, 2024•
edited
Loading

Filter out?NNN type placeholders when looking for named params.

… paramsFilter out '?NNN' type placeholders when looking for named params.
@erlend-aasland
Copy link
ContributorAuthor

cc.@kalekundert

@erlend-aasland
Copy link
ContributorAuthor

@aisk, would you like to review this?

@erlend-aasland
Copy link
ContributorAuthor

I'll merge this early next week. Thanks for chiming in,@aisk :)

@erlend-aaslanderlend-aasland self-assigned thisApr 18, 2024
Co-authored-by: AN Long <aisk@users.noreply.github.com>
@erlend-aasland
Copy link
ContributorAuthor

Thank you so much,@aisk!

aisk reacted with thumbs up emoji

Copy link
Contributor

@felixxmfelixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@erlend-aasland Thanks 👍 Looks good 🚀

erlend-aasland reacted with hooray emoji
@erlend-aasland
Copy link
ContributorAuthor

Thanks for the review, Mariusz!

@erlend-aaslanderlend-aasland merged commit550483b intopython:mainApr 22, 2024
@erlend-aaslanderlend-aasland deleted the sqlite/indexed-nameless-placeholder branchApril 22, 2024 06:43
@miss-islington-app

This comment was marked as outdated.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestApr 22, 2024
… params (pythonGH-118001)Filter out '?NNN' placeholders when looking for named params.(cherry picked from commit550483b)Co-authored-by: Erlend E. Aasland <erlend@python.org>Co-authored-by: AN Long <aisk@users.noreply.github.com>
@bedevere-app
Copy link

GH-118142 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelApr 22, 2024
erlend-aasland added a commit that referenced this pull requestApr 22, 2024
…s params (GH-118001) (#118142)Filter out '?NNN' placeholders when looking for named params.(cherry picked from commit550483b)Co-authored-by: Erlend E. Aasland <erlend@python.org>Co-authored-by: AN Long <aisk@users.noreply.github.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotPPC64LE RHEL7 LTO + PGO 3.x has failed when building commit550483b.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/43/builds/5265) and take a look at the build logs.
  4. Check if the failure is related to this commit (550483b) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/43/builds/5265

Failed tests:

  • test_capi

Summary of the results of the build (if available):

==

Click to see traceback logs
remote:Enumerating objects: 26, done.remote:Counting objects:   3% (1/26)remote:Counting objects:   7% (2/26)remote:Counting objects:  11% (3/26)remote:Counting objects:  15% (4/26)remote:Counting objects:  19% (5/26)remote:Counting objects:  23% (6/26)remote:Counting objects:  26% (7/26)remote:Counting objects:  30% (8/26)remote:Counting objects:  34% (9/26)remote:Counting objects:  38% (10/26)remote:Counting objects:  42% (11/26)remote:Counting objects:  46% (12/26)remote:Counting objects:  50% (13/26)remote:Counting objects:  53% (14/26)remote:Counting objects:  57% (15/26)remote:Counting objects:  61% (16/26)remote:Counting objects:  65% (17/26)remote:Counting objects:  69% (18/26)remote:Counting objects:  73% (19/26)remote:Counting objects:  76% (20/26)remote:Counting objects:  80% (21/26)remote:Counting objects:  84% (22/26)remote:Counting objects:  88% (23/26)remote:Counting objects:  92% (24/26)remote:Counting objects:  96% (25/26)remote:Counting objects: 100% (26/26)remote:Counting objects: 100% (26/26), done.remote:Compressing objects:   7% (1/14)remote:Compressing objects:  14% (2/14)remote:Compressing objects:  21% (3/14)remote:Compressing objects:  28% (4/14)remote:Compressing objects:  35% (5/14)remote:Compressing objects:  42% (6/14)remote:Compressing objects:  50% (7/14)remote:Compressing objects:  57% (8/14)remote:Compressing objects:  64% (9/14)remote:Compressing objects:  71% (10/14)remote:Compressing objects:  78% (11/14)remote:Compressing objects:  85% (12/14)remote:Compressing objects:  92% (13/14)remote:Compressing objects: 100% (14/14)remote:Compressing objects: 100% (14/14), done.remote:Total 14 (delta 12), reused 2 (delta 0), pack-reused 0From https://github.com/python/cpython * branch            main       -> FETCH_HEADNote:checking out '550483b7e6c54b2a25d4db0c4ca41bd9c1132f93'.You are in 'detached HEAD' state. You can look around, make experimentalchanges and commit them, and you can discard any commits you make in thisstate without impacting any branches by performing another checkout.If you want to create a new branch to retain commits you create, you maydo so (now or later) by using -b with the checkout command again. Example:  git checkout -b new_branch_nameHEAD is now at 550483b... gh-117995: Don't raise DeprecationWarnings for indexed nameless params (#118001)Switched to and reset branch 'main'find:‘build’: No such file or directoryfind:‘build’: No such file or directoryfind:‘build’: No such file or directoryfind:‘build’: No such file or directorymake[2]:[Makefile:3082: clean-retain-profile] Error 1 (ignored)Python/Python-ast.c:In function ‘init_types’:Python/Python-ast.c:5478:1: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without init_types(struct ast_state *state) ^~~~~~~~~~./Modules/_testlimitedcapi/unicode.c:In function ‘test_string_from_format’:./Modules/_testlimitedcapi/unicode.c:1416:1: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without test_string_from_format(PyObject *self, PyObject *Py_UNUSED(ignored)) ^~~~~~~~~~~~~~~~~~~~~~~./Modules/_testlimitedcapi/unicode.c:In function ‘test_string_from_format’:./Modules/_testlimitedcapi/unicode.c:1416:1: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without test_string_from_format(PyObject *self, PyObject *Py_UNUSED(ignored)) ^Python/Python-ast.c:In function ‘init_types’:Python/Python-ast.c:5478:1: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without init_types(struct ast_state *state) ^Python/Python-ast.c:In function ‘init_types’:Python/Python-ast.c:5478:1: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without init_types(struct ast_state *state) ^Python/Python-ast.c:In function ‘init_types’:Python/Python-ast.c:5478:1: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without init_types(struct ast_state *state) ^make:*** [Makefile:2229: buildbottest] Error 2

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@aiskaiskaisk approved these changes

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksagberkerpeksag is a code owner

+1 more reviewer

@felixxmfelixxmfelixxm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@erlend-aaslanderlend-aasland

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@erlend-aasland@bedevere-bot@aisk@felixxm
[8]ページ先頭
©2009-2025 Movatter.jp