Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.2k
gh-117755: Remove tests on huge memory allocations#117938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Remove unreliable tests on huge memory allocations:* Remove test_maxcontext_exact_arith() of test_decimal. Stefan Krah, test author, agreed on removing the test:python#114331 (comment)* Remove test_constructor() tests of test_io. Sam Gross suggests remove them:python#117809 (review)On Linux, depending how overcommit is configured, especially on Linuxs390x, a huge memory allocation (half or more of the full addressspace) can succeed, but then the process will eat the full systemswap and make the system slower and slower until the whole systembecomes unusable.Moreover, these tests had to be skipped when Python is built withsanitizers.
@colesbury: Are you ok to remove these tests? |
colesbury approved these changesApr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes
Merged, thanks for the confirmation@colesbury. |
diegorusso pushed a commit to diegorusso/cpython that referenced this pull requestApr 17, 2024
Remove unreliable tests on huge memory allocations:* Remove test_maxcontext_exact_arith() of test_decimal. Stefan Krah, test author, agreed on removing the test:python#114331 (comment)* Remove test_constructor() tests of test_io. Sam Gross suggests remove them:python#117809 (review)On Linux, depending how overcommit is configured, especially on Linuxs390x, a huge memory allocation (half or more of the full addressspace) can succeed, but then the process will eat the full systemswap and make the system slower and slower until the whole systembecomes unusable.Moreover, these tests had to be skipped when Python is built withsanitizers.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Remove unreliable tests on huge memory allocations:
On Linux, depending how overcommit is configured, especially on Linux s390x, a huge memory allocation (half or more of the full address space) can succeed, but then the process will eat the full system swap and make the system slower and slower until the whole system becomes unusable.
Moreover, these tests had to be skipped when Python is built with sanitizers.
test.test_io.CBufferedReaderTest.test_constructorcrash withFloating point exception#117755