Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-117764: Add docstrings and signatures for the types of None, Ellipsis and NotImplemented#117813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
serhiy-storchaka merged 1 commit intopython:mainfromserhiy-storchaka:singleton-types-signaturesApr 12, 2024
Merged
gh-117764: Add docstrings and signatures for the types of None, Ellipsis and NotImplemented#117813
serhiy-storchaka merged 1 commit intopython:mainfromserhiy-storchaka:singleton-types-signaturesApr 12, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
… Ellipsis and NotImplemented
diegorusso pushed a commit to diegorusso/cpython that referenced this pull requestApr 17, 2024
… Ellipsis and NotImplemented (pythonGH-117813)
browniebroke added a commit to browniebroke/django-rest-framework that referenced this pull requestSep 10, 2024
Python 3.13 introduced docstrings for None:python/cpython#117813In Python 3.12, this is an empty string:``` ➜ python3.12Python 3.12.6 (main, Sep 10 2024, 19:06:17) [Clang 15.0.0 (clang-1500.3.9.4)] on darwinType "help", "copyright", "credits" or "license" for more information.>>> d = None>>> d.__doc__>>>```In Python 3.13, it's no longer empty:``` ➜ python3.13Python 3.13.0rc2+ (heads/3.13:660baa1, Sep 10 2024, 18:57:50) [Clang 15.0.0 (clang-1500.3.9.4)] on darwinType "help", "copyright", "credits" or "license" for more information.>>> d = None>>> d.__doc__'The type of the None singleton.'>>>```Adding a check in the inspector that get the view description out the view function docstring to cath this edge case.
browniebroke added a commit to browniebroke/django-rest-framework that referenced this pull requestSep 10, 2024
Python 3.13 introduced docstrings for None:python/cpython#117813In Python 3.12, this is an empty string:``` ➜ python3.12Python 3.12.6 (main, Sep 10 2024, 19:06:17) [Clang 15.0.0 (clang-1500.3.9.4)] on darwinType "help", "copyright", "credits" or "license" for more information.>>> d = None>>> d.__doc__>>>```In Python 3.13, it's no longer empty:``` ➜ python3.13Python 3.13.0rc2+ (heads/3.13:660baa1, Sep 10 2024, 18:57:50) [Clang 15.0.0 (clang-1500.3.9.4)] on darwinType "help", "copyright", "credits" or "license" for more information.>>> d = None>>> d.__doc__'The type of the None singleton.'>>>```Adding a check in the inspector that get the view description out the view function docstring to cath this edge case.
browniebroke added a commit to browniebroke/django-rest-framework that referenced this pull requestSep 10, 2024
Python 3.13 introduced docstrings for None:python/cpython#117813In Python 3.12, this is an empty string:``` ➜ python3.12Python 3.12.6 (main, Sep 10 2024, 19:06:17) [Clang 15.0.0 (clang-1500.3.9.4)] on darwinType "help", "copyright", "credits" or "license" for more information.>>> d = None>>> d.__doc__>>>```In Python 3.13, it's no longer empty:``` ➜ python3.13Python 3.13.0rc2+ (heads/3.13:660baa1, Sep 10 2024, 18:57:50) [Clang 15.0.0 (clang-1500.3.9.4)] on darwinType "help", "copyright", "credits" or "license" for more information.>>> d = None>>> d.__doc__'The type of the None singleton.'>>>```Adding a check in the inspector that get the view description out the view function docstring to catch this edge case.
3 tasks
auvipy pushed a commit to encode/django-rest-framework that referenced this pull requestSep 11, 2024
* Add support for Python 3.13* Fix extracting tox env with -dev Python versions* Fix view description inspection in Python 3.13Python 3.13 introduced docstrings for None:python/cpython#117813In Python 3.12, this is an empty string:``` ➜ python3.12Python 3.12.6 (main, Sep 10 2024, 19:06:17) [Clang 15.0.0 (clang-1500.3.9.4)] on darwinType "help", "copyright", "credits" or "license" for more information.>>> d = None>>> d.__doc__>>>```In Python 3.13, it's no longer empty:``` ➜ python3.13Python 3.13.0rc2+ (heads/3.13:660baa1, Sep 10 2024, 18:57:50) [Clang 15.0.0 (clang-1500.3.9.4)] on darwinType "help", "copyright", "credits" or "license" for more information.>>> d = None>>> d.__doc__'The type of the None singleton.'>>>```Adding a check in the inspector that get the view description out the view function docstring to catch this edge case.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.