Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-76785: Add More Tests to test_interpreters.test_api#117662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrentlyericsnowcurrently commentedApr 9, 2024•
edited by bedevere-appbot
Loading

This is a precursor to sorting out how we handle interpreters created directly via the C-API.

@ericsnowcurrentlyericsnowcurrently added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelApr 10, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@ericsnowcurrently for commit9db5a2b 🤖

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelApr 10, 2024
@ericsnowcurrentlyericsnowcurrently merged commit993c3cc intopython:mainApr 11, 2024
@ericsnowcurrentlyericsnowcurrently deleted the more-interpreters-api-tests branchApril 11, 2024 00:37
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Ubuntu NoGIL 3.x has failed when building commit993c3cc.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1225/builds/1985) and take a look at the build logs.
  4. Check if the failure is related to this commit (993c3cc) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1225/builds/1985

Failed tests:

  • test_math
  • test_tools

Failed subtests:

  • test_flock -main.FNTLEINTRTest.test_flock
  • test_all - test.test_eintr.EINTRTests.test_all
  • test_create_connection_ssl_1 - test.test_asyncio.test_ssl.TestSSL.test_create_connection_ssl_1

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/test_asyncio/test_ssl.py", line385, intest_create_connection_ssl_1    run(client)~~~^^^^^^^^  File"/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/test_asyncio/test_ssl.py", line380, inrunself.loop.run_until_complete(_gather(*tasks))~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^  File"/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/asyncio/base_events.py", line721, inrun_until_completereturn future.result()~~~~~~~~~~~~~^^  File"/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/test_asyncio/test_ssl.py", line371, in_gatherreturnawait asyncio.gather(*tasks)^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/test_asyncio/test_ssl.py", line326, inclient    reader, writer=await asyncio.open_connection(^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^...<3 lines>...**extras)^^^^^^^^^  File"/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/asyncio/streams.py", line48, inopen_connection    transport, _=await loop.create_connection(^^^^^^^^^^^^^^^^^^^^^^^^^^^^^lambda: protocol, host, port,**kwds)^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/asyncio/base_events.py", line1183, increate_connection    transport, protocol=awaitself._create_connection_transport(^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^...<2 lines>...        ssl_shutdown_timeout=ssl_shutdown_timeout)^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/asyncio/base_events.py", line1216, in_create_connection_transportawait waiterConnectionAbortedError:SSL handshake is taking longer than 30.0 seconds: aborting the connectionTraceback (most recent call last):  File"/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/_test_eintr.py", line535, intest_flockself._lock(fcntl.flock,"flock")~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^  File"/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/_test_eintr.py", line517, in_lockraiseException("failed to sync child in%.1f sec"% dt)Exception:failed to sync child in 300.7 secTraceback (most recent call last):  File"/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/test_eintr.py", line17, intest_all    script_helper.run_test_script(script)~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^  File"/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.nogil/build/Lib/test/support/script_helper.py", line316, inrun_test_scriptraiseAssertionError(f"{name} failed")AssertionError:script _test_eintr.py failed

Comment on lines +1417 to +1422
with self.subTest('main'):
expected = _interpreters.new_config('legacy')
expected.gil = 'own'
interpid, *_ = _interpreters.get_main()
config = _interpreters.get_config(interpid)
self.assert_ns_equal(config, expected)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

FYI, this is a duplicate of the above subtest

ericsnowcurrently reacted with thumbs up emoji
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks like this is addressed ingh-117651. I'm fine with fixing it there since it's already done. 😄

ericsnowcurrently added a commit that referenced this pull requestApr 16, 2024
gh-117662 introduced some refleaks, or, rather, exposed some existing refleaks.  The leaks are coming when test.support.os_helper is imported in a "legacy" interpreter.  I've updated test.test_interpreters.utils to avoid importing os_helper, which fixes the leaks.  I'll address the root cause separately.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull requestApr 17, 2024
…h-117662)In addition to the increase test coverage, this is a precursor to sorting out how we handle interpreters created directly via the C-API.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull requestApr 17, 2024
…7913)pythongh-117662 introduced some refleaks, or, rather, exposed some existing refleaks.  The leaks are coming when test.support.os_helper is imported in a "legacy" interpreter.  I've updated test.test_interpreters.utils to avoid importing os_helper, which fixes the leaks.  I'll address the root cause separately.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@colesburycolesburycolesbury left review comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@ericsnowcurrently@bedevere-bot@colesbury
[8]ページ先頭
©2009-2025 Movatter.jp