Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-116608: Ignore UTF-16 BOM in importlib.resources._functional tests#117569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
… testsTo test the `errors` argument, we read a UTF-16 file as UTF-8with "backslashreplace" error handling. However, the utf-16codec adds an endian-specific byte-order mark, so on big-endianmachines the expectation doesn't match the test file (which wassaved on a little-endian machine).Use endswith to ignore the BOM.
!buildbot s390x |
bedevere-bot commentedApr 5, 2024
🤖 New build scheduled with the buildbot fleet by@encukou for commit26ae210 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
@encukou Out of interest, was the |
… tests (pythonGH-117569)pythongh-116609: Ignore UTF-16 BOM in importlib.resources._functional testsTo test the `errors` argument, we read a UTF-16 file as UTF-8with "backslashreplace" error handling. However, the utf-16codec adds an endian-specific byte-order mark, so on big-endianmachines the expectation doesn't match the test file (which wassaved on a little-endian machine).Use endswith to ignore the BOM.
This change needs to be applied to importlib_resources. It looks like a related issue was reported inpython/importlib_resources#312. |
Uh oh!
There was an error while loading.Please reload this page.
To test the
errorsargument, we read a UTF-16 file as UTF-8 with "backslashreplace" error handling. However, the utf-16 codec adds an endian-specific byte-order mark, so on big-endian machines the expectation doesn't match the test file (which was saved on a little-endian machine).Use endswith to ignore the BOM.