Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.3k
gh-116720: Fix corner cases of taskgroups#117407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
21 commits Select commitHold shift + click to select a range
90695c5
Fix taskgroups handling of parent cancellation
gvanrossum6c4876d
When errors and parent cancellation are both pending, re-cancel parent
gvanrossumdf6e8b7
When uncancel() reaches zero, clear _must_cancel
gvanrossumc762e36
Remove 'experimental' comment
gvanrossum4989042
Remove unneeded Py_CLEAR(self->task_cancel_msg)
gvanrossum3f91f2d
Simple test for preserving cancelling() level
gvanrossum55ff73f
Add test for nested task groups
gvanrossum50fd8d6
Add test that is fixed by the re-cancel in __aexit__
gvanrossum93ba76a
Test that uncancel() sets _must_cancel to False
gvanrossumf1f89c0
Move a stray asyncio news item into the asyncio section
gvanrossum48c6dda
Add blurb
gvanrossum1e20728
Add what's new entry
gvanrossumbc1522c
Update uncancel docs
gvanrossum7f6e5ff
Update task group docs
gvanrossum56251ff
Merge remote-tracking branch 'origin/main' into fix-tg
gvanrossumc54fb22
Fix markup error
gvanrossum6d4b3d7
Add attribution to Arthur Tacca issue
gvanrossumb086609
Wording changes suggested by Carol Willing
gvanrossum8ac42f6
Changelog/whatsnew updates from Arthur Tacca
gvanrossumac87a8e
Attempted doc improvements inspired by Arthur Tacca's feedback
gvanrossumbe9365c
Merge remote-tracking branch 'origin/main' into fix-tg
gvanrossumFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Update task group docs
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit7f6e5ffe8fe046aa22e3c668d96c35340d850166
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.