Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-59598: Ignore leading whitespace inJSONDecoder.raw_decode#117397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
crazymerlyn wants to merge1 commit intopython:main
base:main
Choose a base branch
Loading
fromcrazymerlyn:fix-issue-59598

Conversation

crazymerlyn
Copy link

@crazymerlyncrazymerlyn commentedMar 31, 2024
edited by bedevere-appbot
Loading

haampie reacted with thumbs up emoji
@ghost
Copy link

ghost commentedMar 31, 2024
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

Copy link
Contributor

@eendebakpteendebakpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Two small comments, but overall looks good.

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@crazymerlyn
Copy link
Author

Updated the code to make the matching function an argument and removed the extra call.

@eendebakpt
Copy link
Contributor

@crazymerlyn Thanks for the updates. Your pr still requires a news entry. The easiest way to add this is to use click on the Details button next to the failingbedevere/news in the list of CI checks.

Also seehttps://devguide.python.org/core-developers/committing/#how-to-add-a-news-entry

@crazymerlyn
Copy link
Author

added a news entry

@crazymerlyn
Copy link
Author

@eendebakpt Updated with the suggested change.

@eendebakpt
Copy link
Contributor

eendebakpt commentedMay 7, 2024
edited
Loading

@crazymerlyn I read the corresponding issue and opinions on whether we should make this change or not (at least back in 2016!) are not unanimous. A core developer should decide whether to accept this or not. The code in the PR looks good to me.

Since this PR is not backwards compatible and there has been some discussion it is good to update the documentation (e.g. herehttps://docs.python.org/3/library/json.html#json.JSONDecoder.raw_decode) and add aChanged in version x.xx section (for an example seehttps://docs.python.org/3/library/bisect.html#bisect.bisect)

Whitespace is allowed before JSON objects according to RFC 4627.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@eendebakpteendebakpteendebakpt left review comments

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSONDecoder.raw_decode breaks on leading whitespace
2 participants
@crazymerlyn@eendebakpt

[8]ページ先頭

©2009-2025 Movatter.jp