NotificationsYou must be signed in to change notification settings
Fork32.2k
Star67.7k

[WIP] gh-85283: Build _csv extension with limited C API#117321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

vstinner wants to merge1 commit intopython:mainfromvstinner:limited_csv

Closed

[WIP] gh-85283: Build _csv extension with limited C API#117321

vstinner wants to merge1 commit intopython:mainfromvstinner:limited_csv

Conversation

Copy link

Member

vstinner commentedMar 28, 2024•
edited by bedevere-appbot
Loading

Replace PyObject_VectorcallDict() with PyObject_Call() in _call_dialect(). Create a temporary tuple to pass the positional dialect argument.
Use PyUnicode_DecodeUTF32() to create an Unicode string from Py_UCS4 characters.
Replace PyErr_Format("%.200s", Py_TYPE(src)->tp_name) with PyErr_Format("%T", src).
Replace PyUnicode_READ_CHAR() with PyUnicode_ReadChar().
Replace PyUnicode_READ() with PyUnicode_ReadChar(). join_append_lineterminator() now takes an object (Unicode string) as argument.
Replace PyUnicode_GET_LENGTH() with PyUnicode_GetLength().
Replace Py_XSETREF() with assignement and Py_XDECREF().
Replace PyDict_Pop() with PyDict_DelItem().
Use PyType_GetSlot() to get tp_clear and tp_alloc slots.
Add some casts to (PyObject*).
Add an explicit #include <string.h>.

Issue:[C API] Convert a few stdlib extensions to the limited C API (PEP 384) #85283

pythongh-85283: Build _csv extension with limited C API

ee94f36

* Replace PyObject_VectorcallDict() with PyObject_Call() in  _call_dialect(). Create a temporary tuple to pass the positional  dialect argument.* Use PyUnicode_DecodeUTF32() to create an Unicode string from  Py_UCS4 characters.* Replace PyErr_Format("%.200s", Py_TYPE(src)->tp_name) with  PyErr_Format("%T", src).* Replace PyUnicode_READ_CHAR() with PyUnicode_ReadChar().* Replace PyUnicode_READ() with PyUnicode_ReadChar().  join_append_lineterminator() now takes an object (Unicode string)  as argument.* Replace PyUnicode_GET_LENGTH() with PyUnicode_GetLength().* Replace Py_XSETREF() with assignement and Py_XDECREF().* Replace PyDict_Pop() with PyDict_DelItem().* Use PyType_GetSlot() to get tp_clear and tp_alloc slots.* Add some casts to (PyObject*).* Add an explicit #include <string.h>.