Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-76785: Add PyInterpreterConfig Helpers#117170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrentlyericsnowcurrently commentedMar 23, 2024•
edited by bedevere-appbot
Loading

These helpers make it easier to customize and inspect the config used to initialize interpreters. This is especially helpful in our tests. I found inspiration from thePyConfig API for thePyInterpreterConfig dict conversion stuff. One motivation is that, later, we may end up exposing the config via the PEP 734 module.

As part of this PR I've also added a bunch of tests.

@ericsnowcurrentlyericsnowcurrentlyenabled auto-merge (squash)April 2, 2024 20:29
@ericsnowcurrentlyericsnowcurrently merged commitf341d60 intopython:mainApr 2, 2024
@ericsnowcurrentlyericsnowcurrently deleted the interpreter-config-helpers branchApril 2, 2024 20:38
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Ubuntu NoGIL 3.x has failed when building commitf341d60.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1225/builds/1921) and take a look at the build logs.
  4. Check if the failure is related to this commit (f341d60) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1225/builds/1921

Failed tests:

  • test_tools
  • test_math

Summary of the results of the build (if available):

==

Click to see traceback logs
Note:switching to 'f341d6017dd4e80509b69b5a9e2625b71b70f205'.You are in 'detached HEAD' state. You can look around, make experimentalchanges and commit them, and you can discard any commits you make in thisstate without impacting any branches by switching back to a branch.If you want to create a new branch to retain commits you create, you maydo so (now or later) by using -c with the switch command. Example:  git switch -c <new-branch-name>Or undo this operation with:  git switch -Turn off this advice by setting config variable advice.detachedHead to falseHEAD is now at f341d6017d gh-76785: Add PyInterpreterConfig Helpers (gh-117170)Switched to and reset branch 'main'make:*** [Makefile:2230: buildbottest] Error 2

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Ubuntu NoGIL Refleaks 3.x has failed when building commitf341d60.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1226/builds/1600) and take a look at the build logs.
  4. Check if the failure is related to this commit (f341d60) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1226/builds/1600

Failed tests:

  • test_eintr
  • test_import
  • test_capi

Failed subtests:

  • test_mymanager_context_prestarted - test.test_multiprocessing_spawn.test_manager.WithManagerTestMyManager.test_mymanager_context_prestarted
  • test_flock -main.FNTLEINTRTest.test_flock
  • test_all - test.test_eintr.EINTRTests.test_all

Test leaking resources:

  • test_import: references
  • test_capi: memory blocks
  • test_capi: references
  • test_import: memory blocks

Summary of the results of the build (if available):

==

Click to see traceback logs
TracebackTests.test_broken_from) ... okTracebackTests.test_exec_failure_nested) ... okTracebackTests.test_exec_failure) ... okTracebackTests.test_unencodable_filename) ... okTraceback (most recent call last):  File"/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_eintr.py", line535, intest_flockself._lock(fcntl.flock,"flock")~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^  File"/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_eintr.py", line517, in_lockraiseException("failed to sync child in%.1f sec"% dt)Exception:failed to sync child in 300.7 secTracebackTests.test_nonexistent_module) ... okTracebackTests.test_broken_parent_from) ... okTracebackTests.test_nonexistent_module_nested) ... okTracebackTests.test_syntax_error) ... okTracebackTests.test_broken_submodule) ... okTraceback (most recent call last):  File"/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_multiprocessing.py", line3030, intest_mymanager_context_prestartedself.assertEqual(manager._process.exitcode,0)~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError:-15 != 0TracebackTests.test_import_bug) ... okTraceback (most recent call last):  File"/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/test_eintr.py", line17, intest_all    script_helper.run_test_script(script)~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^  File"/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/support/script_helper.py", line316, inrun_test_scriptraiseAssertionError(f"{name} failed")AssertionError:script _test_eintr.py failedTracebackTests.test_broken_parent) ... okTraceback (most recent call last):  File"/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_eintr.py", line535, intest_flockself._lock(fcntl.flock,"flock")~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^  File"/home/ubuntu/buildarea/3.x.itamaro-ubuntu-aws.refleak.nogil/build/Lib/test/_test_eintr.py", line517, in_lockraiseException("failed to sync child in%.1f sec"% dt)Exception:failed to sync child in 300.3 sec

@ericsnowcurrently
Copy link
MemberAuthor

I'm taking care of the refleaks.

ericsnowcurrently added a commit that referenced this pull requestApr 3, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull requestApr 17, 2024
These helpers make it easier to customize and inspect the config used to initialize interpreters.  This is especially valuable in our tests.  I found inspiration from the PyConfig API for the PyInterpreterConfig dict conversion stuff.  As part of this PR I've also added a bunch of tests.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull requestApr 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ericsnowcurrently@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp