Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-116145: Updated bundled Tcl/Tk on Windows to 8.6.14#117030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
zooba merged 3 commits intopython:mainfromzooba:gh-116145
May 31, 2024

Conversation

@zooba
Copy link
Member

@zoobazooba commentedMar 19, 2024
edited by bedevere-appbot
Loading

@terryjreedy
Copy link
Member

terryjreedy commentedMar 20, 2024
edited
Loading

@chrstphrchvz knows about tcl/tk changes.
@serhiy-storchaka is tkinter/ttk code and test maintainer.

Windows x86 testhttps://github.com/python/cpython/actions/runs/8349119889/job/22852588108?pr=117030

*** test tkinter 2 failures: lines 2001-2061
condensed failure:

FAIL: test_itemconfigure (test.test_tkinter.test_widgets.ListboxTest.test_itemconfigure)  File "D:\a\cpython\cpython\Lib\test\test_tkinter\test_widgets.py", line 1002, in test_itemconfigure    self.assertEqual(widget.itemconfigure(0, 'background'),AssertionError: Tuples differ: ('background', '', '', '', 'red') != ('background', 'background', 'Background', '', 'red')FAIL: test_configure_tabs (test.test_tkinter.test_widgets.TextTest.test_configure_tabs)  File "D:\a\cpython\cpython\Lib\test\test_tkinter\test_widgets.py", line 662, in test_configure_tabs    self.checkParam(widget, 'tabs', '10.2 20.7 1i 2i',AssertionError: Tuples differ: (10.2, 20.7, <string object: '1i'>, <string object: '2i'>) != ('10.2', '20.7', '1i', '2i')

*** test audit 1 failure, lines 980-1070: Broken pipe error
I know nothing about this. It passed on rerun, same fail, OK on x64, no failure on free-threading builds.
Perhaps ignore for now.

*** test_ttk failed (8 failures) lines 2066-2265
All are same quoting issue: actual(0,) expected as('0',).

@zoobazooba merged commit0e8d35b intopython:mainMay 31, 2024
@zoobazooba deleted the gh-116145 branchMay 31, 2024 12:07
@zoobazooba added the needs backport to 3.13bugs and security fixes labelMay 31, 2024
@miss-islington-app
Copy link

Thanks@zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 31, 2024
…H-117030)(cherry picked from commit0e8d35b)Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-app
Copy link

GH-119847 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 31, 2024
@serhiy-storchakaserhiy-storchaka added the needs backport to 3.12only security fixes labelMay 31, 2024
@miss-islington-app
Copy link

Thanks@zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@zooba, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 0e8d35b931f41210483cc51c4169e9a943c7f166 3.12

zooba added a commit that referenced this pull requestMay 31, 2024
(cherry picked from commit0e8d35b)Co-authored-by: Steve Dower <steve.dower@python.org>
@zooba
Copy link
MemberAuthor

The macOS change was not backported to 3.12. I don't remember whether we'd consider this a bugfix or a suitable-for-post-beta-pre-RC change, but I'm happy enough to leave it to 3.13 only.

@bedevere-bot

This comment was marked as resolved.

@terryjreedy
Copy link
Member

Hid buildbot failure because test_math and test_statistics not affected by tkinter.

@serhiy-storchaka
Copy link
Member

8.6.14 is a bugfix release. Is there a way for Windows users to update the Tcl/Tk version independently?

@zooba
Copy link
MemberAuthor

Better discuss on the issue, since the macOS maintainers are almost certainly not watching this PR.

@zoobazooba removed their assignmentJun 3, 2024
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull requestJun 12, 2024
…ythonGH-117030)(cherry picked from commit0e8d35b)Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-app
Copy link

GH-120396 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelJun 12, 2024
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull requestJul 11, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull requestJul 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@zwarezwarezware approved these changes

@sethmlarsonsethmlarsonAwaiting requested review from sethmlarsonsethmlarson is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zooba@terryjreedy@bedevere-bot@serhiy-storchaka@zware

[8]ページ先頭

©2009-2025 Movatter.jp