Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-117026: fix wrong sentence in SimpleHTTPRequestHandler#117027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
serhiy-storchaka merged 2 commits intopython:mainfromSalehDehqanpour:patch-1
May 16, 2025

Conversation

SalehDehqanpour
Copy link
Contributor

@SalehDehqanpourSalehDehqanpour commentedMar 19, 2024•
edited by github-actionsbot
Loading

The code does not differentiate between text and binary files so the sentence should be removed from the doc. See#117026

📚 Documentation preview 📚:https://cpython-previews--117027.org.readthedocs.build/

…xt filesThe code does not differentiate between text and binary files so the sentence should be removed from the doc. Seepython#117026
@ghost
Copy link

ghost commentedMar 19, 2024•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

Copy link
Contributor

@davidlowrydudadavidlowryduda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This seems good. But something that confuses me is that it looks like the line of code in server.py has never changed, so it's not like this something that changed from python2 to python3.

This feels like Chesterson's fence.

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. 👍

Thank you for your contribution@SalehDehqanpour.

@serhiy-storchakaserhiy-storchaka added needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes labelsMay 16, 2025
@serhiy-storchakaserhiy-storchakaenabled auto-merge (squash)May 16, 2025 19:08
@serhiy-storchakaserhiy-storchaka merged commitea2d707 intopython:mainMay 16, 2025
24 checks passed
@github-project-automationgithub-project-automationbot moved this fromTodo toDone inDocs PRsMay 16, 2025
@miss-islington-app
Copy link

Thanks@SalehDehqanpour for the PR, and@serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 16, 2025
… docs (pythonGH-117027)The code was changed in0f7cddc (bpo-839496/pythongh-39531).(cherry picked from commitea2d707)Co-authored-by: Saleh Dehqanpour <salehdeh76@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 16, 2025
… docs (pythonGH-117027)The code was changed in0f7cddc (bpo-839496/pythongh-39531).(cherry picked from commitea2d707)Co-authored-by: Saleh Dehqanpour <salehdeh76@gmail.com>
@bedevere-app
Copy link

GH-134107 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMay 16, 2025
@bedevere-app
Copy link

GH-134108 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 16, 2025
serhiy-storchaka pushed a commit that referenced this pull requestMay 16, 2025
…r docs (GH-117027) (GH-134107)The code was changed in0f7cddc (bpo-839496/gh-39531).(cherry picked from commitea2d707)Co-authored-by: Saleh Dehqanpour <salehdeh76@gmail.com>
serhiy-storchaka pushed a commit that referenced this pull requestMay 16, 2025
…r docs (GH-117027) (GH-134108)The code was changed in0f7cddc (bpo-839496/gh-39531).(cherry picked from commitea2d707)Co-authored-by: Saleh Dehqanpour <salehdeh76@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@davidlowrydudadavidlowrydudadavidlowryduda left review comments

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip news
Projects
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@SalehDehqanpour@davidlowryduda@serhiy-storchaka
[8]ページ先頭
©2009-2025 Movatter.jp