Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-85283: Build _statistics extension with the limited C API#116927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 1 commit intopython:mainfromvstinner:limited_statistics
Mar 17, 2024

Conversation

vstinner
Copy link
Member

@vstinnervstinner commentedMar 17, 2024•
edited by bedevere-appbot
Loading

Argument Clinic now inlines _PyArg_CheckPositional() for the limited C API. The generated code should be as fast or even a little bit faster.

@vstinner
Copy link
MemberAuthor

I made a previous attempt last August: PRgh-108500. It made _statistics._normal_dist_inv_cdf() 2x slower because of the usage of the legacy METH_VARARGS calling convention, instead of more recent and faster METH_FASTCALL.

This new attempt keeps METH_FASTCALL thanks to recent Argument Clinic changes, and so it has no impact on performance. Or maybe it's a little bit faster thanks to inlining.

cc@serhiy-storchaka@erlend-aasland

Argument Clinic now inlines _PyArg_CheckPositional() for the limitedC API. The generated code should be as fast or even a little bitfaster.
@vstinnervstinner merged commit2982bdb intopython:mainMar 17, 2024
@vstinnervstinner deleted the limited_statistics branchMarch 17, 2024 17:59
vstinner added a commit to vstinner/cpython that referenced this pull requestMar 20, 2024
…ython#116927)Argument Clinic now inlines _PyArg_CheckPositional() for the limitedC API. The generated code should be as fast or even a little bitfaster.
adorilson pushed a commit to adorilson/cpython that referenced this pull requestMar 25, 2024
…ython#116927)Argument Clinic now inlines _PyArg_CheckPositional() for the limitedC API. The generated code should be as fast or even a little bitfaster.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull requestApr 17, 2024
…ython#116927)Argument Clinic now inlines _PyArg_CheckPositional() for the limitedC API. The generated code should be as fast or even a little bitfaster.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@vstinner@serhiy-storchaka
[8]ページ先頭
©2009-2025 Movatter.jp