Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.2k
GH-115802: Reduce the size of _INIT_CALL_PY_EXACT_ARGS.#116856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
markshannon merged 1 commit intopython:mainfromfaster-cpython:attempt-to-shrink-call-sequenceMar 15, 2024
Merged
GH-115802: Reduce the size of _INIT_CALL_PY_EXACT_ARGS.#116856
markshannon merged 1 commit intopython:mainfromfaster-cpython:attempt-to-shrink-call-sequenceMar 15, 2024
+54 −72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
13 tasks
Fidget-Spinner approved these changesMar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Test failure is the usual suspect oftest_multiprocessing. Probably just flaky.
Nice find! There are lots of other instructions with this pattern... should those be updated too? |
vstinner pushed a commit to vstinner/cpython that referenced this pull requestMar 20, 2024
adorilson pushed a commit to adorilson/cpython that referenced this pull requestMar 25, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull requestApr 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Small tweak to reduce the size of the stencils for
_INIT_CALL_PY_EXACT_ARGSThe base version goes from 983 to 652 bytes (linux x86-64) and the
_0replica goes from 440 to 258 bytes.