Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-111696, PEP 737: Add PyType_GetModuleName() function#116824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Author: Eric Snow <ericsnowcurrently@gmail.com>
@ericsnowcurrently: since your implemented the function, I added you as a co-author :-) |
@vstinner What was so incredibly urgent that you couldn't wait for anyone to review this? |
Well, I'm working on the PEP 737 since 2018, the implementation is quite straightforward, the API got approved by the Steering Council, so I was justhappy to finally see my work being approved, so I merged the changes. This specific change only makes an existing API public. In 2018, I reverted changes and started this discussion which didn't go anywhere:https://mail.python.org/archives/list/python-dev@python.org/thread/HKYUMTVHNBVB5LJNRMZ7TPUQKGKAERCJ/ Last November, I gave a new try:https://discuss.python.org/t/enhance-type-name-formatting-when-raising-an-exception-add-t-format-in-c-and-add-type-fullyqualname/38129 Yesterday, finally, the Steering Council approved my PEP after I made the changes they requested ;-) |
…#116824)Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
…#116824)Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
…#116824)Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
Author: Eric Snowericsnowcurrently@gmail.com
📚 Documentation preview 📚:https://cpython-previews--116824.org.readthedocs.build/