NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.8k

[3.11] gh-88352: Make TimedRotatingFileHandler tests more stable (GH-116409)#116586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

serhiy-storchaka merged 1 commit intopython:3.11frommiss-islington:backport-d8712fa-3.11

Mar 11, 2024

Merged

[3.11] gh-88352: Make TimedRotatingFileHandler tests more stable (GH-116409)#116586

serhiy-storchaka merged 1 commit intopython:3.11frommiss-islington:backport-d8712fa-3.11

Mar 11, 2024

Conversation

Copy link

Contributor

miss-islington commentedMar 11, 2024•
edited by bedevere-appbot
Loading

The tests failed (with less than 1% probability) if for example the file
was created at 11:46:03.999, but the record was emitted at 11:46:04.001,
with atTime=11:46:04, which caused an unexpected rollover. Ensure that the
tests are always run within the range of the same whole second.

Also share code between test_rollover_at_midnight and test_rollover_at_weekday.
(cherry picked from commitd8712fa)

Co-authored-by: Serhiy Storchakastorchaka@gmail.com

Issue:TimedRotatingFileHandler overwrite log #88352

pythongh-88352: Make TimedRotatingFileHandler tests more stable (pyth…

0b11c16

…onGH-116409)The tests failed (with less than 1% probability) if for example the filewas created at 11:46:03.999, but the record was emitted at 11:46:04.001,with atTime=11:46:04, which caused an unexpected rollover. Ensure that thetests are always run within the range of the same whole second.Also share code between test_rollover_at_midnight and test_rollover_at_weekday.(cherry picked from commitd8712fa)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>