Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-116386: Fix format string "%ld" warning in_xxinterpqueuesmodule#116387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sobolevn merged 2 commits intopython:mainfromsobolevn:issue-116386
Mar 7, 2024

Conversation

@sobolevn
Copy link
Member

@sobolevnsobolevn commentedMar 5, 2024•
edited by bedevere-appbot
Loading

Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. No warnings on macOS.

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Would not be more natural to use the%zd format string?

And this looks like a completely different issue than the originally reported one.

@ericsnowcurrently
Copy link
Member

Would not be more natural to use the%zd format string?

Yeah, that was a copy-paste failure on my part. I shouldn't have usedPRId64 for_queue.count since it isPy_ssize_t, notint64_t. Using%zd sounds right.

And this looks like a completely different issue than the originally reported one.

This is a fix for my fix (gh-116369) for that originally reported issue.

@bedevere-app
Copy link

When you're done making the requested changes, leave the comment:I have made the requested changes; please review again.

Copy link
Member

@ericsnowcurrentlyericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@sobolevn
Copy link
MemberAuthor

Thanks for the help and reviews!

@ericsnowcurrently
Copy link
Member

Thanks for fixing this. 😄

adorilson pushed a commit to adorilson/cpython that referenced this pull requestMar 25, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull requestApr 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka left review comments

@ericsnowcurrentlyericsnowcurrentlyericsnowcurrently approved these changes

@gvanrossumgvanrossumgvanrossum approved these changes

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sobolevn@ericsnowcurrently@gvanrossum@serhiy-storchaka
[8]ページ先頭
©2009-2025 Movatter.jp