Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-115103: Enable internal mimalloc assertions in debug builds#116343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This sets `MI_DEBUG` to `2` in debug builds to enable`mi_assert_internal()` calls. Expensive internal assertions are notenabled.This also disables an assertion in free-threaded builds that would betriggered by the free-threaded GC because we traverse heaps that are notowned by the current thread.
!buildbot nogil |
bedevere-bot commentedMar 4, 2024
🤖 New build scheduled with the buildbot fleet by@colesbury for commitd336146 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
The context is that the changes to mimalloc related to QSBR would benefit from the internal assertions being enabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
…ython#116343)This sets `MI_DEBUG` to `2` in debug builds to enable `mi_assert_internal()`calls. Expensive internal assertions are not enabled.This also disables an assertion in free-threaded builds that would betriggered by the free-threaded GC because we traverse heaps that are notowned by the current thread.
…ython#116343)This sets `MI_DEBUG` to `2` in debug builds to enable `mi_assert_internal()`calls. Expensive internal assertions are not enabled.This also disables an assertion in free-threaded builds that would betriggered by the free-threaded GC because we traverse heaps that are notowned by the current thread.
Uh oh!
There was an error while loading.Please reload this page.
This sets
MI_DEBUGto2in debug builds to enablemi_assert_internal()calls. Expensive internal assertions are not enabled.This also disables an assertion in free-threaded builds that would be triggered by the free-threaded GC because we traverse heaps that are not owned by the current thread.