NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.7k

[3.12] gh-88352: Fix logging.TimedRotatingFileHandler (GH-116191)#116208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

serhiy-storchaka merged 1 commit intopython:3.12frommiss-islington:backport-fee86fd-3.12

Mar 1, 2024

Merged

[3.12] gh-88352: Fix logging.TimedRotatingFileHandler (GH-116191)#116208

serhiy-storchaka merged 1 commit intopython:3.12frommiss-islington:backport-fee86fd-3.12

Mar 1, 2024

Conversation

Copy link

Contributor

miss-islington commentedMar 1, 2024•
edited by bedevere-appbot
Loading

Do not overwrite already rolled over files. It happened at midnight or
during the DST change and caused the loss of data.
computeRollover() now always return the timestamp larger than the
specified time.
Fix computation of the rollover time during the DST change.
(cherry picked from commitfee86fd)

Co-authored-by: Serhiy Storchakastorchaka@gmail.com

Issue:TimedRotatingFileHandler overwrite log #88352

pythongh-88352: Fix logging.TimedRotatingFileHandler (pythonGH-116191)

d76f0d4

* Do not overwrite already rolled over files. It happened at midnight or  during the DST change and caused the loss of data.* computeRollover() now always return the timestamp larger than the  specified time.* Fix computation of the rollover time during the DST change.(cherry picked from commitfee86fd)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>