Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-87115: Set__main__.__spec__ toNone in pdb#116141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
iritkatriel merged 2 commits intopython:mainfromgaogaotiantian:fix-pdb-spec
Feb 29, 2024

Conversation

@gaogaotiantian
Copy link
Member

@gaogaotiantiangaogaotiantian commentedFeb 29, 2024•
edited by bedevere-appbot
Loading

__main__.__spec__ should beNone when running a script, butpdb does not set it in the namespace. This breaks some code that relies on it (that__spec__ exists in__main__).

@gaogaotiantian
Copy link
MemberAuthor

Hey@iritkatriel could you take a quick look at this? This is a trivial fix - just to set__spec__ toNone for script targets. This is a bug fix so it probably should be backported.

@gaogaotiantiangaogaotiantian added needs backport to 3.11only security fixes needs backport to 3.12only security fixes labelsFeb 29, 2024
@iritkatrieliritkatrielenabled auto-merge (squash)February 29, 2024 21:36
@iritkatrieliritkatriel merged commitccfc042 intopython:mainFeb 29, 2024
@miss-islington-app
Copy link

Thanks@gaogaotiantian for the PR, and@iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@gaogaotiantian and@iritkatriel, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker ccfc042bbf31e53c44b8aae444afd8365b798422 3.12

@miss-islington-app
Copy link

Sorry,@gaogaotiantian and@iritkatriel, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker ccfc042bbf31e53c44b8aae444afd8365b798422 3.11

@gaogaotiantian
Copy link
MemberAuthor

I'll work on the cp. I thought the fix is trivial enough so there should not be any conflicts.

@gaogaotiantiangaogaotiantian deleted the fix-pdb-spec branchFebruary 29, 2024 21:41
gaogaotiantian added a commit to gaogaotiantian/cpython that referenced this pull requestFeb 29, 2024
gaogaotiantian added a commit to gaogaotiantian/cpython that referenced this pull requestFeb 29, 2024
…onGH-116141)(cherry picked from commitccfc042)Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
@bedevere-app
Copy link

GH-116154 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelFeb 29, 2024
@bedevere-app
Copy link

GH-116155 is a backport of this pull request to the3.11 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.11only security fixes labelFeb 29, 2024
gaogaotiantian added a commit to gaogaotiantian/cpython that referenced this pull requestFeb 29, 2024
gaogaotiantian added a commit to gaogaotiantian/cpython that referenced this pull requestFeb 29, 2024
…onGH-116141)(cherry picked from commitccfc042)Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
iritkatriel pushed a commit that referenced this pull requestFeb 29, 2024
…#116154)*gh-87115: Set `__main__.__spec__` to `None` in pdb (#116141)(cherry picked from commitccfc042)* [3.12]gh-87115: Set `__main__.__spec__` to `None` in pdb (GH-116141)(cherry picked from commitccfc042)Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
iritkatriel pushed a commit that referenced this pull requestFeb 29, 2024
…#116155)*gh-87115: Set `__main__.__spec__` to `None` in pdb (#116141)(cherry picked from commitccfc042)* [3.11]gh-87115: Set `__main__.__spec__` to `None` in pdb (GH-116141)(cherry picked from commitccfc042)Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
@encukouencukou mentioned this pull requestMar 4, 2024
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull requestMar 4, 2024
adorilson pushed a commit to adorilson/cpython that referenced this pull requestMar 25, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull requestApr 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@iritkatrieliritkatrieliritkatriel approved these changes

Assignees

@iritkatrieliritkatriel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gaogaotiantian@iritkatriel
[8]ページ先頭
©2009-2025 Movatter.jp