Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-89547: Add support for nesting special forms like Final#116092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
hmc-cs-mdrissi wants to merge1 commit intopython:mainfromhmc-cs-mdrissi:support_nested_special_forms
Closed
gh-89547: Add support for nesting special forms like Final#116092
hmc-cs-mdrissi wants to merge1 commit intopython:mainfromhmc-cs-mdrissi:support_nested_special_forms
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ghost commentedFeb 29, 2024
The following commit authors need to sign the Contributor License Agreement: Click the button to sign: |
Hmm, for CLA it's probably easier if I close and remake the PR with email of this account. That's my work email, which has a github account, but it's github enterprise account and unsure how to sign with it. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Resolves thisissue. The main goal was to permit
ClassVar[Final[int]]andFinal[ClassVar[int]]. This drops validation check that Final/ClassVar argument is not a special form.This does allow some silly cases like
ClassVar[ClassVar[int]]but I think it's simpler to allow them then have more complex validation rules at runtime. I did not remove special form check for other forms soUnion[ClassVar[int], int]remains forbidden andlist[ClassVar[int]]is also forbidden. There already was a test case thatlist[ClassVar[int]]fails.I also added couple tests for Annotated to ensure it can nest freely with
ClassVar/Final.