Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-115961: Add name and mode attributes for compressed file-like objects#116036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
serhiy-storchaka merged 4 commits intopython:mainfromserhiy-storchaka:compress-file-name-modeApr 21, 2024
Merged
gh-115961: Add name and mode attributes for compressed file-like objects#116036
serhiy-storchaka merged 4 commits intopython:mainfromserhiy-storchaka:compress-file-name-modeApr 21, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…e objects* Add name and mode attributes for compressed and archived file-like objects in modules bz2, lzma, tarfile and zipfile.* Change the value of the mode attribute of GzipFile from integer (1 or 2) to string ('rb' or 'wb').* Change the value of the mode attribute of ZipExtFile from 'r' to 'rb'.223fd79 to874c8ebCompareeendebakpt approved these changesApr 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good! Some changes are not backwards compatible, but every change is properly documented.
gpshead approved these changesApr 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice. This is much more consistent across all our file like ducks.
I'm not worried about things like the old gzip 1 and 2 values as I don't expect anyone to ever have used them. Similar for the old 'r' that should've been a 'rb'.
If anything comes up depending on this during the betas we can revisit.
bedevere-bot commentedApr 21, 2024
|
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
📚 Documentation preview 📚:https://cpython-previews--116036.org.readthedocs.build/