All commit authors signed the Contributor License Agreement.

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

I have made the requested changes; please review again.

I cannot do a commit review of this as it is out of my expertise. I requested reviews from two coredevs who have edited the file most recently.

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

They are pretty new features (xz.tukaani.org/format/xz-file-format-1.2.0.txt):

        1.2.0     2024-01-19    Added RISC-V filter and updated URLs in                                Sections 0.2 and 7. The URL of this                                specification was changed.        1.1.0     2022-12-11    Added ARM64 filter and clarified 32-bit                                ARM endianness in Section 5.3.2,                                language improvements in Section 5.4

Adding support for them is a new feature in Python, so you need to add versionadded or versionchanged directives in the module documentation and add the corresponding entry in the What's New file.

You should also specify that the new filters (work? are supported? are available?) only with the specified XZ (library? file format?) version. Please add tests for new filters. They should produce expected result or raise an expected exception depending on the xz version.

I am not sure whether these constants should be defined if the underlying library does not support them. The new tests should show what is better.

OK. Done. Correct my if anything is missing.

I think we should lock the PR right now until things get clear and maybe after the xz code base is audited.

this PRitself seems fine and is the kind of thing we want, though the fate of the upstream code is certainly unknown at the moment it isn't related to this specific issue. (I removed the added binary test data)

@serhiy-storchaka - I'm glad we agree on what needs doing in this PR! I hope I'm not stepping on your toes by going ahead and doing some of that today. =)

Alright, I believe this is ready. I'll let@serhiy-storchaka do the final review and merge.

exposing the decimal number from the C library probably isn't right, I like Serhiy's larger issue. These can be structured (tuple). The code to do so won't be much different thanks to Py_BuildValue APIs.

and we can elide the LZMA_ prefix on the names and not include them in__all__. They're in the lzma module after all.

Merged latest main branch and adjusted available version number. Please review.

!buildbot onder-riscv64

The regex 'onder-riscv64' did not match any buildbot builder. Is the requested builder in the list of stable builders?

!buildbot riscv64

🤖 New build scheduled with the buildbot fleet by@furkanonder for commit1a17fd5 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F115989%2Fmerge

The command will test the builders whose names match following regular expression:riscv64

The builders matched are:

• riscv64 Ubuntu23 PR