Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-115942: Addlocked to several multiprocessing locks#115944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sobolevn merged 10 commits intopython:mainfromsobolevn:issue-115942
Apr 8, 2025

Conversation

sobolevn
Copy link
Member

@sobolevnsobolevn commentedFeb 26, 2024•
edited
Loading

TODO:

  • Get field-expert's approval
  • Docs
  • News

ccaruceru, Eclips4, and AprogramG reacted with thumbs up emoji
@sobolevn
Copy link
MemberAuthor

@gpshead do you have an opinion about this? :)

@sobolevn
Copy link
MemberAuthor

friendly ping@gpshead

Co-authored-by: mpage <mpage@cs.stanford.edu>
@gpshead
Copy link
Member

FWIW this PR makes sense to me.

@sobolevn
Copy link
MemberAuthor

Ok, then I will add all the missing details. Thanks a lot! 👍

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please add tests on threading.RLock.locked().

Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just some rewording. Otherwise, once tests requested by Victor are added, LGTM.

@sobolevn
Copy link
MemberAuthor

@vstinner@gpshead this is now ready to be reviewed :)

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

sobolevn reacted with heart emoji
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Copy link
Member

@gpsheadgpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I wish I could object to this being a locked() method instead of a .locked property... but this is matching an existing ancient API on purpose so... LGTM.

sobolevn reacted with heart emoji
@sobolevnsobolevn merged commitf7305a0 intopython:mainApr 8, 2025
42 checks passed
@sobolevn
Copy link
MemberAuthor

Thanks everyone! 🎉

ccaruceru and vstinner reacted with hooray emoji

seehwan pushed a commit to seehwan/cpython that referenced this pull requestApr 16, 2025
…n#115944)Co-authored-by: mpage <mpage@cs.stanford.edu>Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hugovkhugovkhugovk left review comments

@gpsheadgpsheadgpshead approved these changes

@vstinnervstinnervstinner approved these changes

@picnixzpicnixzpicnixz approved these changes

@mpagempageAwaiting requested review from mpage

@brettcannonbrettcannonAwaiting requested review from brettcannonbrettcannon is a code owner

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@ncoghlanncoghlanAwaiting requested review from ncoghlanncoghlan is a code owner

@warsawwarsawAwaiting requested review from warsawwarsaw is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@sobolevn@gpshead@vstinner@mpage@hugovk@picnixz
[8]ページ先頭
©2009-2025 Movatter.jp