Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
gh-71052: Add test exclusions to support running the test suite on Android#115918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
c5bec30 tof2e8385CompareUh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
| os.chdir(os.sep) | ||
| self.assertEqual(set(os.listdir()), set(os.listdir(os.sep))) | ||
| # The root directory is not readable on Android, so use a directory | ||
| # we created ourselves. | ||
| os.chdir(self.dir) | ||
| self.assertEqual(set(os.listdir()), expected) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
looks good
@erlend-aasland: You reviewed the equivalent PR for iOS (#114889); would you like to take a look at this one for Android? It's much smaller. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good to me; thanks!
Uh oh!
There was an error while loading.Please reload this page.
This PR builds on#114889 by@freakboy3742. It marks Android as not supporting subprocesses, and skips some additional tests which can't be run on this platform.
Some multiprocessing-related test changes have been submitted separately in#115917.