Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-96471: Correct docs for queue shutdown raises#115838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

EpicWink
Copy link
Contributor

@EpicWinkEpicWink commentedFeb 23, 2024•
edited
Loading

  • Remove "raises ShutDown" fromQueue.join() andQueue.task_done() documentation (including doc-string)
  • ClarifyQueue.shutdown() behaviour (it doesn't raise itself, but causes other methods to raise)
  • Add thatQueue.task_done() is called byQueue.shutdown(immediate=True) for each item in the queue

Caused by:#104750

📚 Documentation preview 📚:https://cpython-previews--115838.org.readthedocs.build/

@bedevere-appbedevere-appbot mentioned this pull requestFeb 23, 2024
@EpicWinkEpicWinkforce-pushed thethreading-queue-shutdown-no-raise-docs branch from4fdeb68 to63bdd42CompareFebruary 23, 2024 02:09
@EpicWinkEpicWinkforce-pushed thethreading-queue-shutdown-no-raise-docs branch from63bdd42 toc1bcb5dCompareFebruary 23, 2024 02:10
Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! Two nits and then I'll merge this. (I feel bad that I didn't catch this in review.)

@rhettingerrhettinger removed their request for reviewFebruary 23, 2024 05:34
gvanrossum

This comment was marked as duplicate.

Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please fix the nits I called out.

@bedevere-app
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@EpicWink
Copy link
ContributorAuthor

I have made the requested changes; please review again

@gvanrossumgvanrossumenabled auto-merge (squash)February 25, 2024 16:31
@gvanrossumgvanrossum merged commit9402ea6 intopython:mainFeb 25, 2024
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull requestMar 4, 2024
@EpicWinkEpicWink deleted the threading-queue-shutdown-no-raise-docs branchApril 11, 2024 01:10
diegorusso pushed a commit to diegorusso/cpython that referenced this pull requestApr 17, 2024
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull requestJan 22, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@gvanrossumgvanrossumgvanrossum approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@EpicWink@gvanrossum
[8]ページ先頭
©2009-2025 Movatter.jp