Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.2k
GH-115802: JIT "small" code for macOS and Linux#115826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I minor issue with an assert, otherwise looks good.
| { | ||
| unsigned char rd = get_bits(loc32[0], 0, 5); | ||
| assert(IS_AARCH64_LDR_OR_STR(loc32[1])); | ||
| unsigned char rt = get_bits(loc32[1], 0, 5); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
rt andrn are only used in the assert, so I'm getting an unused variable warning.
| assert(IS_AARCH64_LDR_OR_STR(loc32[1])); | ||
| unsigned char rt = get_bits(loc32[1], 0, 5); | ||
| unsigned char rn = get_bits(loc32[1], 5, 5); | ||
| assert(rd == rn && rn == rt); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| assert(rd==rn&&rn==rt); | |
| assert(rd==get_bits(loc32[1],5,5)&&rd==get_bits(loc32[1],0,5)); |
| @@ -121,21 +122,14 @@ async def _compile( | |||
| "-fno-builtin", | |||
| # SET_FUNCTION_ATTRIBUTE on 32-bit Windows debug builds: | |||
| "-fno-jump-tables", | |||
| # Position-independent code adds indirection to every load and jump: | |||
| "-fno-pic", | |||
| "-fno-plt", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could you make sure each option has a comment saying what it does.
When you're done making the requested changes, leave the comment: |
Sorry, looks like I merged just before your review. I'll address these in the follow-up Windows PR. |
Uh oh!
There was an error while loading.Please reload this page.
Windows will come next, since that uses a different mechanism.
Somewhere in the neighborhood of~0-3% faster, as expected.