NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

gh-110850: Rename internal PyTime C API functions#115734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vstinner merged 2 commits intopython:mainfromvstinner:pytime_rename

Feb 20, 2024

Merged

gh-110850: Rename internal PyTime C API functions#115734

vstinner merged 2 commits intopython:mainfromvstinner:pytime_rename

Feb 20, 2024

Conversation

Copy link

Member

vstinner commentedFeb 20, 2024•
edited by bedevere-appbot
Loading

Rename functions:

_PyTime_GetSystemClock() => _PyTime_TimeUnchecked()
_PyTime_GetPerfCounter() => _PyTime_PerfCounterUnchecked()
_PyTime_GetMonotonicClock() => _PyTime_MonotonicUnchecked()
_PyTime_GetSystemClockWithInfo() => _PyTime_TimeWithInfo()
_PyTime_GetMonotonicClockWithInfo() => _PyTime_MonotonicWithInfo()
_PyTime_GetMonotonicClockWithInfo() => _PyTime_MonotonicWithInfo()

Changes:

Remove "typedef PyTime_t PyTime_t;" which was "typedef PyTime_t _PyTime_t;" before a previous rename.
Update comments of "Unchecked" functions.
Remove invalid PyTime_Time() comment.

Issue:Please expose _PyTime_t, _PyTime_FromTimeval, and _PyTime_AsSecondsDouble as public APIs #110850

pythongh-110850: Rename internal PyTime C API functions

cdffb00

Rename functions:* _PyTime_GetSystemClock() => _PyTime_TimeUnchecked()* _PyTime_GetPerfCounter() => _PyTime_PerfCounterUnchecked()* _PyTime_GetMonotonicClock() => _PyTime_MonotonicUnchecked()* _PyTime_GetSystemClockWithInfo() => _PyTime_TimeWithInfo()* _PyTime_GetMonotonicClockWithInfo() => _PyTime_MonotonicWithInfo()* _PyTime_GetMonotonicClockWithInfo() => _PyTime_MonotonicWithInfo()Changes:* Remove "typedef PyTime_t PyTime_t;" which was  "typedef PyTime_t _PyTime_t;" before a previous rename.* Update comments of "Unchecked" functions.* Remove invalid PyTime_Time() comment.

vstinner added skip news 3.13bugs and security fixes labels

Feb 20, 2024

vstinner requested review fromrhettinger,pganssle,abalkin,ericsnowcurrently andkumaraditya303 ascode owners

February 20, 2024 17:33

bedevere-appbot added the awaiting core review label

Feb 20, 2024

bedevere-appbot mentioned this pull request

Feb 20, 2024

Please expose _PyTime_t, _PyTime_FromTimeval, and _PyTime_AsSecondsDouble as public APIs#110850

Closed

vstinnerenabled auto-merge (squash)

February 20, 2024 17:34

Fix make check-c-globals

d435b32

vstinner merged commit52d1477 intopython:main

Feb 20, 2024

vstinner deleted the pytime_rename branch

February 20, 2024 22:16

bedevere-appbot removed the awaiting core review label

Feb 20, 2024

woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request

Mar 4, 2024

pythongh-110850: Rename internal PyTime C API functions (python#115734)

de60ec0

Rename functions:* _PyTime_GetSystemClock() => _PyTime_TimeUnchecked()* _PyTime_GetPerfCounter() => _PyTime_PerfCounterUnchecked()* _PyTime_GetMonotonicClock() => _PyTime_MonotonicUnchecked()* _PyTime_GetSystemClockWithInfo() => _PyTime_TimeWithInfo()* _PyTime_GetMonotonicClockWithInfo() => _PyTime_MonotonicWithInfo()* _PyTime_GetMonotonicClockWithInfo() => _PyTime_MonotonicWithInfo()Changes:* Remove "typedef PyTime_t PyTime_t;" which was  "typedef PyTime_t _PyTime_t;" before a previous rename.* Update comments of "Unchecked" functions.* Remove invalid PyTime_Time() comment.

diegorusso pushed a commit to diegorusso/cpython that referenced this pull request

Apr 17, 2024

pythongh-110850: Rename internal PyTime C API functions (python#115734)

51d19fe

Rename functions:* _PyTime_GetSystemClock() => _PyTime_TimeUnchecked()* _PyTime_GetPerfCounter() => _PyTime_PerfCounterUnchecked()* _PyTime_GetMonotonicClock() => _PyTime_MonotonicUnchecked()* _PyTime_GetSystemClockWithInfo() => _PyTime_TimeWithInfo()* _PyTime_GetMonotonicClockWithInfo() => _PyTime_MonotonicWithInfo()* _PyTime_GetMonotonicClockWithInfo() => _PyTime_MonotonicWithInfo()Changes:* Remove "typedef PyTime_t PyTime_t;" which was  "typedef PyTime_t _PyTime_t;" before a previous rename.* Update comments of "Unchecked" functions.* Remove invalid PyTime_Time() comment.

LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull request

Jan 22, 2025

pythongh-110850: Rename internal PyTime C API functions (python#115734)

e26a2ad

Rename functions:* _PyTime_GetSystemClock() => _PyTime_TimeUnchecked()* _PyTime_GetPerfCounter() => _PyTime_PerfCounterUnchecked()* _PyTime_GetMonotonicClock() => _PyTime_MonotonicUnchecked()* _PyTime_GetSystemClockWithInfo() => _PyTime_TimeWithInfo()* _PyTime_GetMonotonicClockWithInfo() => _PyTime_MonotonicWithInfo()* _PyTime_GetMonotonicClockWithInfo() => _PyTime_MonotonicWithInfo()Changes:* Remove "typedef PyTime_t PyTime_t;" which was  "typedef PyTime_t _PyTime_t;" before a previous rename.* Update comments of "Unchecked" functions.* Remove invalid PyTime_Time() comment.