Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-114626: Add again _PyCFunctionFastWithKeywords name#115561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
encukou merged 1 commit intopython:mainfromvstinner:with_kwds
Feb 19, 2024

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commentedFeb 16, 2024
edited by bedevere-appbot
Loading

Keep the old private _PyCFunctionFastWithKeywords name (Python 3.7) as an alias to the new public name PyCFunctionFastWithKeywords (Python 3.13a4).

_PyCFunctionWithKeywords doesn't exist in Python 3.13a3, whereas _PyCFunctionFastWithKeywords was removed in Python 3.13a4.

Keep the old private _PyCFunctionFastWithKeywords name (Python 3.7)as an alias to the new public name PyCFunctionFastWithKeywords(Python 3.13a4)._PyCFunctionWithKeywords doesn't exist in Python 3.13a3, whereas_PyCFunctionFastWithKeywords was removed in Python 3.13a4.
@vstinner
Copy link
MemberAuthor

cc@davidhewitt@encukou

@davidhewitt
Copy link
Contributor

Thank you for fixing & sorry for the typo!

@vstinner
Copy link
MemberAuthor

vstinner commentedFeb 16, 2024
edited
Loading

_PyCFunctionWithKeywords name never existed. Example in Python 3.12:

$ cd ~/python/3.12$ git grep '_PyCFunctionWithKeywords\>' || echo "NOT FOUND"NOT FOUND

versus

$ git grep '\<PyCFunctionWithKeywords\>' || echo "NOT FOUND"Doc/c-api/structures.rst:.. c:type:: PyCFunctionWithKeywordsDoc/c-api/structures.rst:      PyObject *PyCFunctionWithKeywords(PyObject *self,Doc/c-api/structures.rst:   Methods with these flags must be of type :c:type:`PyCFunctionWithKeywords`.Doc/data/stable_abi.dat:type,PyCFunctionWithKeywords,3.2,,Include/internal/pycore_object.h:        (*(PyCFunctionWithKeywords)(void(*)(void))(meth)), (self), (args), NULL)Include/internal/pycore_object.h:    PyCFunctionWithKeywords meth, PyObject *, PyObject *, PyObject *);Include/methodobject.h:typedef PyObject *(*PyCFunctionWithKeywords)(PyObject *, PyObject *,Misc/stable_abi.toml:[typedef.PyCFunctionWithKeywords]Objects/call.c:            (PyCFunctionWithKeywords)call, callable, argstuple, kwdict);Objects/descrobject.c:    PyCFunctionWithKeywords meth = (PyCFunctionWithKeywords)Objects/methodobject.c:            (*(PyCFunctionWithKeywords)(void(*)(void))meth),Objects/methodobject.c:EM_JS(PyObject*, _PyCFunctionWithKeywords_TrampolineCall, (PyCFunctionWithKeywords func, PyObject *self, PyObject *args, PyObject *kw), {

@encukou
Copy link
Member

Thank you. I also apologize for letting this through.

@encukouencukou merged commitaa8c1a0 intopython:mainFeb 19, 2024
@vstinnervstinner deleted the with_kwds branchFebruary 19, 2024 13:18
@vstinner
Copy link
MemberAuthor

Thank you. I also apologize for letting this through.

Honestly, even after I read the first change twice, I didn't notice that it was a mistake ("typo") to remove the alias. These names are misleading :-(

befeleme pushed a commit to fedora-python/cpython that referenced this pull requestFeb 22, 2024
…ythonGH-115561)Keep the old private _PyCFunctionFastWithKeywords name (Python 3.7)as an alias to the new public name PyCFunctionFastWithKeywords(Python 3.13a4)._PyCFunctionWithKeywords doesn't exist in Python 3.13a3, whereas_PyCFunctionFastWithKeywords was removed in Python 3.13a4.
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull requestMar 4, 2024
…H-115561)Keep the old private _PyCFunctionFastWithKeywords name (Python 3.7)as an alias to the new public name PyCFunctionFastWithKeywords(Python 3.13a4)._PyCFunctionWithKeywords doesn't exist in Python 3.13a3, whereas_PyCFunctionFastWithKeywords was removed in Python 3.13a4.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull requestApr 17, 2024
…H-115561)Keep the old private _PyCFunctionFastWithKeywords name (Python 3.7)as an alias to the new public name PyCFunctionFastWithKeywords(Python 3.13a4)._PyCFunctionWithKeywords doesn't exist in Python 3.13a3, whereas_PyCFunctionFastWithKeywords was removed in Python 3.13a4.
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull requestJan 22, 2025
…H-115561)Keep the old private _PyCFunctionFastWithKeywords name (Python 3.7)as an alias to the new public name PyCFunctionFastWithKeywords(Python 3.13a4)._PyCFunctionWithKeywords doesn't exist in Python 3.13a3, whereas_PyCFunctionFastWithKeywords was removed in Python 3.13a4.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner@davidhewitt@encukou

[8]ページ先頭

©2009-2025 Movatter.jp