Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-112529: Use _PyThread_Id() in mimalloc (free-threaded build)#115488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The free-threaded GC uses mimallocs segment thread IDs to restorethe overwritten `ob_tid` thread ids in PyObjects. For that reason, it'simportant that PyObjects and mimalloc use the same identifiers.
3 tasks
DinoV approved these changesFeb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
colesbury added a commit to colesbury/cpython that referenced this pull requestFeb 15, 2024
…ded build"Reverts:python#115488Reason: Free-threaded Ubuntu buildbots are timing out
daanx added a commit to microsoft/mimalloc that referenced this pull requestMay 19, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The free-threaded GC uses mimallocs segment thread IDs to restore the overwritten
ob_tidthread ids in PyObjects. For that reason, it's important that PyObjects and mimalloc use the same identifiers.--disable-gilbuilds #112529