NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.3k

bpo-24780: unittest assertEqual difference output foiled by newlines#11548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

nanjekyejoannah wants to merge3 commits intopython:masterfromnanjekyejoannah:issue24780

Closed

bpo-24780: unittest assertEqual difference output foiled by newlines#11548

nanjekyejoannah wants to merge3 commits intopython:masterfromnanjekyejoannah:issue24780

Conversation

Copy link

Contributor

nanjekyejoannah commentedJan 14, 2019•
edited
Loading

I have created a fix for this issue and relevant tests.

https://bugs.python.org/issue24780

the-knights-who-say-ni added the CLA signed label

Jan 14, 2019

bedevere-bot added the awaiting review label

Jan 14, 2019

tirkarthi reviewed

Jan 14, 2019

View reviewed changes

Lib/unittest/case.py

		@@ -1238,6 +1238,11 @@ def assertCountEqual(self, first, second, msg=None):
		msg = self._formatMessage(msg, standardMsg)
		self.fail(msg)

		def addTrailingNewLine(self, line):
		if line != '' and (line[-1] != '\n' or line[-1] != ' '):
		line = line + '\n'

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the PR.line is a list here and this causes test failures due toTypeError.lines seems to be a better name since it makes me think it's a single line but it's actually a list of lines.

Lib/unittest/test/test_case.py

		class AssertEqualTest(unittest.TestCase):

		def test_trailing_new_line_at_end(self):
		self.assertEqual("abc\n", "abc\n")

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think a better test would be to test the output diff likehttps://github.com/python/cpython/blob/e709c1be97a04156c628f534116a236b9581aa2f/Lib/unittest/test/test_case.py#L1122 and it should be testing the failure cases and asserting the Exception output string.

nanjekyejoannah force-pushed theissue24780 branch from222a928 todf4bdc9Compare

January 16, 2019 08:53

unittest assertEqual difference output foiled by newlines

819b341

nanjekyejoannah force-pushed theissue24780 branch from6467b25 to819b341Compare

January 16, 2019 09:06

blurb-itbotand others added2 commits

January 16, 2019 09:11

📜🤖 Added by blurb_it.

28bd893

fix space

00190f8

Copy link

ContributorAuthor

nanjekyejoannah commentedJan 22, 2019

@tirkarthi I made the necessary updates to this PR.

Copy link

Member

tirkarthi commentedJan 22, 2019

Thanks@nanjekyejoannah, tests should be fixed as noted inhttps://github.com/python/cpython/pull/11548/files#r247392463 . The tests are about the strings being equal and are not related to the issue. The actual tests should be about the diff output for the tests.