Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-100414: Skip test_dbm_sqlite3 if sqlite3 is unavailable#115449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedFeb 14, 2024•
edited by bedevere-appbot
Loading

@erlend-aasland

This comment was marked as outdated.

@bedevere-bot

This comment was marked as outdated.

@erlend-aasland

This comment was marked as outdated.

@bedevere-bot

This comment was marked as outdated.

@erlend-aasland
Copy link
ContributorAuthor

I think I prefer this fix.

AlexWaygood reacted with thumbs up emoji

Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

See my comments in#115448 (comment). This feels slightly more fragile to me, in that whether or not the test passes depends on the order the imports are in, which isn't necessarily obvious to the reader of the test. But either is probably fine; no strong preference :)

@AlexWaygood
Copy link
Member

This feels slightly more fragile to me, in that whether or not the test passes depends on the order the imports are in, which isn't necessarily obvious to the reader of the test.

You could maybe add a comment noting that the imports need to be in precisely that order

erlend-aasland reacted with thumbs up emoji

@erlend-aasland
Copy link
ContributorAuthor

You could maybe add a comment noting that the imports need to be in precisely that order

Yes, that seems fair to the future reader.

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@erlend-aaslanderlend-aaslandenabled auto-merge (squash)February 14, 2024 12:28
@erlend-aasland
Copy link
ContributorAuthor

Thanks for the review(s), Alex!

AlexWaygood reacted with rocket emoji

@AlexWaygood
Copy link
Member

No worries!

@encukou
Copy link
Member

!buildbot AMD64 RHEL7

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@encukou for commitd9a099c 🤖

The command will test the builders whose names match following regular expression:AMD64 RHEL7

The builders matched are:

  • AMD64 RHEL7 LTO PR
  • AMD64 RHEL7 PR
  • AMD64 RHEL7 Refleaks PR
  • AMD64 RHEL7 LTO + PGO PR

@erlend-aaslanderlend-aasland merged commit029ec91 intopython:mainFeb 14, 2024
@erlend-aaslanderlend-aasland deleted the dbm/alt-fix-sqlite3-backend branchFebruary 14, 2024 13:16
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull requestFeb 14, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksagberkerpeksag is a code owner

Assignees
No one assigned
Labels
skip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@erlend-aasland@bedevere-bot@AlexWaygood@encukou@serhiy-storchaka
[8]ページ先頭
©2009-2025 Movatter.jp