Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-115119: Detect _decimal dependencies using pkg-config#115406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
erlend-aasland merged 8 commits intopython:mainfromerlend-aasland:ac/libmpdec
Apr 29, 2024

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedFeb 13, 2024•
edited by bedevere-appbot
Loading

Only libmpdec 4.0.0 supports pkg-config.

thesamesam reacted with thumbs up emoji
@bedevere-appbedevere-appbot mentioned this pull requestFeb 13, 2024
15 tasks
@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commentedFeb 13, 2024•
edited
Loading

Tested on macOS with the following scenarios:

$./configure&& make# Uses CPython vendored mpdecimal$./configure --with-system-libmpdec&& make# pkg-config detects Homebrew installed libmpdec 4.0.0$LIBMPDEC_CFLAGS="-I$HOME/install" \  LIBMPDEC_LIBS="-L$HOME/install -lm -lmpdec" \  ./configure --with-system-libmpdec && make  # Build with custom libmpdec 2.5.1

For some reason the latter fails, but I suspect it is an issue with my setup.

@erlend-aasland
Copy link
ContributorAuthor

cc.@ned-deily

@rhettingerrhettinger removed their request for reviewMarch 30, 2024 19:21
Copy link
Member

@ned-deilyned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks! FWIW, I was able to successfully build and test with mpdecimal 2.5.1 as well as 4.0.0.

erlend-aasland reacted with hooray emoji
@erlend-aasland
Copy link
ContributorAuthor

Thanks, Ned! I had forgotten about this :)

@erlend-aaslanderlend-aasland merged commitc7e7bfc intopython:mainApr 29, 2024
36 checks passed
@erlend-aaslanderlend-aasland deleted the ac/libmpdec branchApril 29, 2024 06:58
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ned-deilyned-deilyned-deily approved these changes

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

@zwarezwareAwaiting requested review from zware

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@erlend-aasland@ned-deily
[8]ページ先頭
©2009-2025 Movatter.jp