Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[3.8] gh-115349: Pin theme to fix code snippets (GH-115351)#115404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 1 commit intopython:3.8fromambv:backport-3fcea41-3.8
Feb 13, 2024

Conversation

ambv
Copy link
Contributor

@ambvambv commentedFeb 13, 2024
edited by bedevere-appbot
Loading

Pin theme to fix code snippets
(cherry picked from commit3fcea41)

…-115351)Pin theme to fix code snippets(cherry picked from commit3fcea41)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Built locally:

image

@ambv
Copy link
ContributorAuthor

@hugovk I appreciate it but this was about the dark theme, no?

@hugovk
Copy link
Member

Yes, we're pinning to the last versionbefore the dark theme was added.

This the minimal fix, because the dark theme requires Sphinx 3 for proper syntax highlighting, and the 3.8/3.9 docs use Sphinx 2.4.4.

We can look into bumping Sphinx to 3+, but it will likely also require bumping other dependencies, and for security branches I felt it would be easier/safer to pin to an older python-docs-theme.

@ambv
Copy link
ContributorAuthor

Ah, got it. Right. Okay then, let's go.

hugovk reacted with thumbs up emoji

@ambvambv merged commita21c0c7 intopython:3.8Feb 13, 2024
@ambvambv deleted the backport-3fcea41-3.8 branchFebruary 13, 2024 13:44
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hugovkhugovkhugovk approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ambv@hugovk

[8]ページ先頭

©2009-2025 Movatter.jp