Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-114570: Add PythonFinalizationError exception#115352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
Add PythonFinalizationError exception. This exception derived fromRuntimeError is raised when an operation is blocked during the Pythonfinalization.The following functions now raise PythonFinalizationError, instead ofRuntimeError:* _thread.start_new_thread()* subprocess.Popen* os.fork()* os.fork1()* os.forkpty()Morever, _winapi.Overlapped finalizer now logs an unraisablePythonFinalizationError, instead of an unraisable RuntimeError.
6d096b9 to30bd9c9ComparePR rebased on main to attempt to fix the macos-13 CI issue. |
Merged. Thanks for the review@gpshead and@serhiy-storchaka. |
Uh oh!
There was an error while loading.Please reload this page.
Add PythonFinalizationError exception. This exception derived from RuntimeError is raised when an operation is blocked during the Python finalization.
The following functions now raise PythonFinalizationError, instead of RuntimeError:
Morever, _winapi.Overlapped finalizer now logs an unraisable PythonFinalizationError, instead of an unraisable RuntimeError.
sys.is_finalizingbefore thread.start() still yields "can't create new thread at interpreter shutdown" #114570📚 Documentation preview 📚:https://cpython-previews--115352.org.readthedocs.build/