Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-101100: Fix Sphinx warnings inwhatsnew/2.7.rst
and related#115319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
whatsnew/2.7.rst
and relatedwhatsnew/2.7.rst
and relatedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice! A couple of minor suggestions:
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
A few more, sorry!
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
* The:attr:`sys.version_info` value is now a named tuple, with attributes | ||
named :attr:`!major`, :attr:`!minor`, :attr:`!micro`, | ||
:attr:`!releaselevel`, and :attr:`!serial`. (Contributed by Ross | ||
Light; :issue:`4285`.) | ||
:func:`sys.getwindowsversion` also returns a named tuple, | ||
with attributes named :attr:`major`, :attr:`minor`, :attr:`build`, | ||
:attr:`platform`, :attr:`service_pack`, :attr:`service_pack_major`, | ||
:attr:`service_pack_minor`, :attr:`suite_mask`, and | ||
:attr:`product_type`. (Contributed by Brian Curtin; :issue:`7766`.) | ||
with attributes named :attr:`!major`, :attr:`!minor`, :attr:`!build`, | ||
:attr:`!platform`, :attr:`!service_pack`, :attr:`!service_pack_major`, | ||
:attr:`!service_pack_minor`, :attr:`!suite_mask`, and | ||
:attr:`!product_type`. (Contributed by Brian Curtin; :issue:`7766`.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
(It's possible to link to all of these attributes directly, I think -- but I agree that there's no need to do so; it would just be distracting for the reader. No change requested! :)
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks! Looks good other than my question at#115319 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
(Some line-length nits)
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Always welcome, thank you for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
🚀
Uh oh!
There was an error while loading.Please reload this page.
Thanks@hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
Sorry,@hugovk, I could not cleanly backport this to
|
Sorry,@hugovk, I could not cleanly backport this to
|
GH-115330 is a backport of this pull request to the3.12 branch. |
… related (pythonGH-115319)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>.(cherry picked from commit92483b2)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
GH-115331 is a backport of this pull request to the3.11 branch. |
… related (pythonGH-115319)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>.(cherry picked from commit92483b2)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
python#115319)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
Fixes most of the Sphinx reference warnings in
whatsnew/2.7.rst
, plus some related fixes in other files, 108 warnings in all:The remaining 17 warnings in
2.7.rst
might be things that need documenting; I've left them for another time:📚 Documentation preview 📚:https://cpython-previews--115319.org.readthedocs.build/