Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
Revert "gh-96471: Add shutdown() method to queue.Queue (#104750)"#115265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
…104750)"Reason for the revert:python#115258test_queue timed out on Windows free-threading build.The PR author had mentioned this inpython#104750 (comment)but I forgot about it and merged anyway.This reverts commitb2d9d13.
@EpicWink Just letting you know your PR might be reverted. Don't worry, we can resubmit we disable the offending test. We may also be able to avoid reverting the whole PR by just disabling that test, if we're convinced the problem is restricted to the combination of free-threading, Windows, and that specific test. |
terryjreedy commentedFeb 11, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
After reviewing the added code, I suggest immediately reverting the failing test on Windows free-thread builds to stop interfering with good PRs, and monitor for other CI/buildbot failures, while investigating. I was thinking about debug prints but then saw the note on the original PR that they themselves cause failures. EDIT: side note line 241: n_items is not used in this function as _qsize is re-called each loop. |
gvanrossum commentedFeb 11, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Closing in favor of#115269 which disables the offending tests on Windows. |
Uh oh!
There was an error while loading.Please reload this page.
Reason for the revert:#115258 test_queue timed out on Windows free-threading build.
The PR author had mentioned this in
#104750 (comment) but I forgot about it and merged anyway.
This reverts commitb2d9d13.
📚 Documentation preview 📚:https://cpython-previews--115265.org.readthedocs.build/