Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-115256: Remove refcycles from tarfile writing#115257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
encukou merged 6 commits intopython:mainfrompan324:refcycle-tarfiles
Mar 4, 2024

Conversation

pan324
Copy link
Contributor

@pan324pan324 commentedFeb 10, 2024•
edited by bedevere-appbot
Loading

@encukouencukouenabled auto-merge (squash)March 4, 2024 13:04
@encukouencukou merged commit0dfa7ce intopython:mainMar 4, 2024
@AlexWaygood
Copy link
Member

Not the biggest issue in the world, but it's a shame the PR title wasn't changed here before it was merged. The title of the resulting commit is pretty inaccurate :(

pan324 reacted with thumbs up emojiencukou reacted with confused emoji

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Debian root 3.x has failed when building commit0dfa7ce.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/345/builds/7318) and take a look at the build logs.
  4. Check if the failure is related to this commit (0dfa7ce) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/345/builds/7318

Failed tests:

  • test_bytes
  • test_difflib
  • test_tokenize
  • test_io
  • test_statistics
  • test_pickle

Failed subtests:

  • test_threads - test.test_io.CBufferedReaderTest.test_threads
  • test_dict_chunking - test.test_pickle.CPicklerTests.test_dict_chunking
  • test_recursion_limit - test.test_difflib.TestSFpatches.test_recursion_limit
  • test_threads - test.test_io.PyBufferedRandomTest.test_threads
  • test_inv_cdf - test.test_statistics.TestNormalDistPython.test_inv_cdf
  • test_random_files - test.test_tokenize.TestRoundtrip.test_random_files

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_tokenize.py", line1959, intest_random_filesself.check_roundtrip(f)~~~~~~~~~~~~~~~~~~~~^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_tokenize.py", line1825, incheck_roundtrip    bytes_from5= tokenize.untokenize(tokens5)~~~~~~~~~~~~~~~~~~~^^^^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/tokenize.py", line333, inuntokenize    out= ut.untokenize(iterable)~~~~~~~~~~~~~^^^^^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/tokenize.py", line249, inuntokenizeself.add_whitespace(start)~~~~~~~~~~~~~~~~~~~^^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/tokenize.py", line176, inadd_whitespaceif row<self.prev_rowor row==self.prev_rowand col<self.prev_col:^^^^^^^^^^^^^^^^^^^TypeError:'<' not supported between instances of 'Untokenizer' and 'int'Traceback (most recent call last):  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_statistics.py", line2951, intest_inv_cdfself.assertAlmostEqual(iq.cdf(iq.inv_cdf(p)), p)~~~~~~~~~~^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/statistics.py", line1496, ininv_cdfif p<=0.0or p>=1.0:^^^^^^^^TypeError:'<=' not supported between instances of 'NormalDist' and 'float'Traceback (most recent call last):  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_io.py", line2430, intest_threads    BufferedReaderTest.test_threads(self)~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_io.py", line1574, intest_threads    random.shuffle(l)~~~~~~~~~~~~~~^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/random.py", line361, inshuffle    x[i], x[j]= x[j], x[i]~^^^TypeError:list indices must be integers or slices, not RandomTraceback (most recent call last):  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_difflib.py", line252, intest_recursion_limit    difflib.SequenceMatcher(None, old, new).get_opcodes()~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/difflib.py", line525, inget_opcodesfor ai, bj, sizeinself.get_matching_blocks():~~~~~~~~~~~~~~~~~~~~~~~~^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/difflib.py", line454, inget_matching_blocks    i, j, k= x=self.find_longest_match(alo, ahi, blo, bhi)~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/difflib.py", line386, infind_longest_matchif k> bestsize:^^^^^^^^^^^^TypeError:'>' not supported between instances of 'SequenceMatcher' and 'int'Traceback (most recent call last):  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/pickletester.py", line2279, intest_dict_chunking    num_setitems= count_opcode(pickle.SETITEMS, s)~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/pickletester.py", line68, incount_opcodefor op, dummy, dummyin pickletools.genops(pickle):if op.code== code.decode("latin-1"):            n+=1  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/pickletools.py", line2279, in_genops    code= data.read(1)~~~~~~~~~^^^TypeError:'_io.BytesIO' object is not callableTraceback (most recent call last):  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_io.py", line1574, intest_threads    random.shuffle(l)~~~~~~~~~~~~~~^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/random.py", line361, inshuffle    x[i], x[j]= x[j], x[i]~^^^TypeError:'Random' object does not support item assignmentTraceback (most recent call last):  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/string_tests.py", line347, intest_find_periodic_pattern    check_pattern(rr)~~~~~~~~~~~~~^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/string_tests.py", line339, incheck_pattern    right=''.join(choices('abcdef',k=rr(2000)))~~~~~~~^^^^^^^^^^^^^^^^^^^^^^  File"/root/buildarea/3.x.angelico-debian-amd64/build/Lib/random.py", line471, inchoicesreturn [population[floor(random()* n)]for iin _repeat(None, k)]~~~~~~^^TypeError:'Random' object is not callable

@encukou
Copy link
Member

That failure looks quite unrelated.

pan324 reacted with thumbs up emoji

woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull requestMar 4, 2024
adorilson pushed a commit to adorilson/cpython that referenced this pull requestMar 25, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull requestApr 17, 2024
donBarbos added a commit to donBarbos/typeshed that referenced this pull requestApr 27, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@encukouencukouencukou approved these changes

@ethanfurmanethanfurmanAwaiting requested review from ethanfurmanethanfurman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@pan324@AlexWaygood@bedevere-bot@encukou
[8]ページ先頭
©2009-2025 Movatter.jp