NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

gh-103092: Adapt _lsprof methods to Argument Clinic#115242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

aisk wants to merge8 commits intopython:mainfromaisk:lsprof-clinic

Closed

gh-103092: Adapt _lsprof methods to Argument Clinic#115242

aisk wants to merge8 commits intopython:mainfromaisk:lsprof-clinic

Conversation

Copy link

Member

aisk commentedFeb 10, 2024•
edited by bedevere-appbot
Loading

This is split from#115130 as pre-processing to isolate the _lsprof module.

Some methods have added a cls: defining_class parameter to their signature but do not use it. This is because#115130 will use it to passing module state.

@erlend-aasland

Issue:Isolate Stdlib Extension Modules #103092

aisk added3 commits

February 10, 2024 19:52

Apply Clinic Argument _lsprof

1ad2f1e

Apply CA to clear method

3a7cd9d

Revert unused change

05d0f09

bedevere-appbot added the awaiting review label

Feb 10, 2024

bedevere-appbot mentioned this pull request

Feb 10, 2024

Isolate Stdlib Extension Modules#103092

Open

25 tasks

aisk added2 commits

February 10, 2024 20:18

Revert change which has been edited by accident

06df9c1

Re-order the Profiler methods in codes

ca454e2

erlend-aasland added the skip news label

Feb 10, 2024

Copy link

Contributor

erlend-aasland commentedFeb 10, 2024

A couple of remarks after a quick glance¹:

It seems there are many similar signatures; consider using the AC "clone" feature
The defining class converter should be marked as positional-only (/)
Style nit: can you use a more concise clinic input block:
- drop the extra newline between/*[clinic input] and the function def
- drop the extra newline between the function def and the parameter section