Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

GH-113710: Backedge counter improvements.#115166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@markshannon
Copy link
Member

@markshannonmarkshannon commentedFeb 8, 2024•
edited by bedevere-appbot
Loading

The PR clarifies the handling of counters and triggering of the optimizer inJUMP_BACKWARD.

This PR:

  • Clarifies the manual 2s complement conversion.
  • Avoids relying on truncation to 16 bits
  • Does the shifting and offset calculation when setting the optimizer, rather than on every back edge.
  • Hides the handling of the NULL/default optimizer.

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@markshannonmarkshannon merged commitf9f6156 intopython:mainFeb 13, 2024
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull requestFeb 14, 2024
@gvanrossum
Copy link
Member

@markshannon FWIW, even after this PR I find it hard to follow how the Tier 2 optimization backoff counters are managed. The bit fiddling is exceedingly complicated. Maybe we should have some macros for these, like we do for specialization counters.

@markshannonmarkshannon deleted the clarify-backedge-counter branchAugust 6, 2024 10:17
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland left review comments

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@gvanrossumgvanrossumAwaiting requested review from gvanrossum

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@markshannon@gvanrossum@erlend-aasland
[8]ページ先頭
©2009-2025 Movatter.jp