Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[3.11] gh-101100: Fix Py_DEBUG dangling Sphinx references (#115003)#115141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AlexWaygood merged 1 commit intopython:3.11fromsmontanaro:backport-d0322fd-3.11
Feb 7, 2024

Conversation

smontanaro
Copy link
Contributor

@smontanarosmontanaro commentedFeb 7, 2024
edited by bedevere-appbot
Loading

No change to 3.11 branch forDoc/library/test.rst because the relevant section was new in 3.12.


📚 Documentation preview 📚:https://cpython-previews--115141.org.readthedocs.build/

@AlexWaygoodAlexWaygood changed the titleBackport d0322fd 3.11[3.11] gh-101100: Fix Py_DEBUG dangling Sphinx references (#115003)Feb 7, 2024
@AlexWaygood
Copy link
Member

@smontanaro, please make sure to select the correct base branch when creating backport PRs. If you try to merge a 3.11 backport PR into themain branch (what you originally did here), you end up pinging all active core developers due to how GitHub's CODEOWNERS feature works :)

@AlexWaygoodAlexWaygoodenabled auto-merge (squash)February 7, 2024 17:13
@AlexWaygoodAlexWaygood merged commite1e4cf7 intopython:3.11Feb 7, 2024
@smontanaro
Copy link
ContributorAuthor

@smontanaro, please make sure to select the correct base branch when creating backport PRs. If you try to merge a 3.11 backport PR into themain branch (what you originally did here), you end up pinging all active core developers due to how GitHub's CODEOWNERS feature works :)

I was on my 3.11 branch. In addition, thecherry_picker command includes the branch on the command line. I have no idea why the PR in GitHub is against the main branch. I think I'm doing everything right.

@zware
Copy link
Member

zware commentedFeb 7, 2024
edited
Loading

The branch was created correctly, based on3.11. The the PR was not, though, itsbase branch wasmain (GitHub is not aware enough to care about long-lived branches and thus choose the correct base branch on its own). How are you opening the PR? If it'scherry_picker opening it on its own (I can't remember whether it does that, it hasn't been working for me for other reasons lately :) ), it may have a bug.

AlexWaygood and serhiy-storchaka reacted with thumbs up emoji

@smontanaro
Copy link
ContributorAuthor

The branch was created correctly, based on3.11. The PR was not, though, itsbase branch wasmain...

Ah, that's the problem. It hadn't occurred to me that there was a choice to make at that step. I thought everything would just be correct. The first time I even tried to make a PR against anything butmain was a few days ago. I clearly need to up my game in this regard. Apologies for the problem.

zware and AlexWaygood reacted with heart emoji

@terryjreedy
Copy link
Member

terryjreedy commentedFeb 8, 2024
edited
Loading

This sort of splat is common enough that must of us now know to check further emails to see if someone has already handled it before even clicking to do anything. Please keep contributing.

This one was solved by re-basing and close/open to restart tests. Force-pushing sometimes results in a mess that requires closing and starting over with a new PR.

Alex, Zachary: could we ask GH to add a way to clear the reviewer request list? Or either question or refuse to create PRs like this? Or add a hook that calls our codebefore making the PR? EDIT Or have we tried already?

AlexWaygood, gpshead, and hugovk reacted with thumbs up emoji

@AlexWaygood
Copy link
Member

This sort of splat is common enough that must of us now know to check further emails to see if someone has already handled it before even clicking to do anything. Please keep contributing.

+1. Apologies if my first message was overly critical,@smontanaro :)

Alex, Zachary: could we ask GH to add a way to clear the reviewer request list? Or either question or refuse to create PRs like this? Or add a hook that calls our codebefore making the PR? EDIT Or have we tried already?

I recall us giving some informal feedback to GitHub some time ago that it would be nice to introduce some more friction to the PR-making process, to make this kind of thing less common. But I don't know that anything came of it; it might well be worth trying again

@smontanaro
Copy link
ContributorAuthor

No worries. You didn't put me off... In fact:

https://discuss.python.org/t/dis-py-stack-append-vs-stack-push/45330

AlexWaygood and gpshead reacted with heart emoji

@smontanarosmontanaro deleted the backport-d0322fd-3.11 branchMarch 13, 2024 00:54
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@smontanaro@AlexWaygood@zware@terryjreedy

[8]ページ先頭

©2009-2025 Movatter.jp