Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-115011: Improve support of __index__() in setters of members with unsigned integer type#115029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
serhiy-storchaka merged 2 commits intopython:mainfromserhiy-storchaka:structmembers-assign-indexFeb 11, 2024
Merged
gh-115011: Improve support of __index__() in setters of members with unsigned integer type#115029
serhiy-storchaka merged 2 commits intopython:mainfromserhiy-storchaka:structmembers-assign-indexFeb 11, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
… with unsigned integer typeSetters for members with an unsigned integer type now supportthe same range of valid values for objects that has a __index__()method as for int.Previously, Py_T_UINT, Py_T_ULONG and Py_T_ULLONG did not supportobjects that has a __index__() method larger than LONG_MAX.Py_T_ULLONG did not support negative ints. Now it supports them andemits a RuntimeWarning.
MemberAuthor
serhiy-storchaka commentedFeb 8, 2024
Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
Sorry,@serhiy-storchaka, I could not cleanly backport this to |
Sorry,@serhiy-storchaka, I could not cleanly backport this to |
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull requestFeb 11, 2024
…members with unsigned integer type (pythonGH-115029)Setters for members with an unsigned integer type now supportthe same range of valid values for objects that has a __index__()method as for int.Previously, Py_T_UINT, Py_T_ULONG and Py_T_ULLONG did not supportobjects that has a __index__() method larger than LONG_MAX.Py_T_ULLONG did not support negative ints. Now it supports them andemits a RuntimeWarning.(cherry picked from commitd9d6909)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
GH-115294 is a backport of this pull request to the3.12 branch. |
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull requestFeb 11, 2024
…members with unsigned integer type (pythonGH-115029)Setters for members with an unsigned integer type now supportthe same range of valid values for objects that has a __index__()method as for int.Previously, Py_T_UINT, Py_T_ULONG and Py_T_ULLONG did not supportobjects that has a __index__() method larger than LONG_MAX.Py_T_ULLONG did not support negative ints. Now it supports them andemits a RuntimeWarning.(cherry picked from commitd9d6909)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
GH-115295 is a backport of this pull request to the3.11 branch. |
serhiy-storchaka added a commit that referenced this pull requestFeb 11, 2024
…s with unsigned integer type (GH-115029) (GH-115294)Setters for members with an unsigned integer type now supportthe same range of valid values for objects that has a __index__()method as for int.Previously, Py_T_UINT, Py_T_ULONG and Py_T_ULLONG did not supportobjects that has a __index__() method larger than LONG_MAX.Py_T_ULLONG did not support negative ints. Now it supports them andemits a RuntimeWarning.(cherry picked from commitd9d6909)
serhiy-storchaka added a commit that referenced this pull requestFeb 11, 2024
…s with unsigned integer type (GH-115029) (GH-115295)Setters for members with an unsigned integer type now supportthe same range of valid values for objects that has a __index__()method as for int.Previously, Py_T_UINT, Py_T_ULONG and Py_T_ULLONG did not supportobjects that has a __index__() method larger than LONG_MAX.Py_T_ULLONG did not support negative ints. Now it supports them andemits a RuntimeWarning.(cherry picked from commitd9d6909)
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull requestFeb 14, 2024
… with unsigned integer type (pythonGH-115029)Setters for members with an unsigned integer type now supportthe same range of valid values for objects that has a __index__()method as for int.Previously, Py_T_UINT, Py_T_ULONG and Py_T_ULLONG did not supportobjects that has a __index__() method larger than LONG_MAX.Py_T_ULLONG did not support negative ints. Now it supports them andemits a RuntimeWarning.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Setters for members with an unsigned integer type now support the same range of valid values for objects that has a
__index__()method as for int.Previously, Py_T_UINT, Py_T_ULONG and Py_T_ULLONG did not support objects that has a
__index__()method larger than LONG_MAX.Py_T_ULLONG did not support negative ints. Now it supports them and emits a RuntimeWarning.