Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-101100: Fix dangling refs in bdb.rst#114983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 4 commits intopython:mainfromsmontanaro:patch-2
Feb 11, 2024
Merged

Conversation

smontanaro
Copy link
Contributor

@smontanarosmontanaro commentedFeb 4, 2024•
edited by github-actionsbot
Loading

This should be fairly straightforward. I did one thing that isn't maybe strictly kosher. TheBdb.quitting attribute isn't directly documented, but is mentioned in the description ofBdb.set_quit(). I linked those occurrences to the description ofset_quit.

📚 Documentation preview 📚:https://cpython-previews--114983.org.readthedocs.build/

Co-authored-by: AN Long <aisk@users.noreply.github.com>
Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

@hugovk
Copy link
Member

@smontanaro Please could you update this PR to removebdb.rst from.nitignore?

Congratulations! You improved:

Doc/library/bdb.rst

Please remove from Doc/tools/.nitignore

@hugovkhugovk added needs backport to 3.11only security fixes needs backport to 3.12only security fixes labelsFeb 10, 2024
@smontanaro
Copy link
ContributorAuthor

@hugovk Should be all set. If my aim at the start of one of these mini-projects is to get rid of all warnings from a file, should my initial PR remove it from.nitignore?

@hugovk
Copy link
Member

Yes please, we can consider each PR to be atomic so both (clean file, remove from .nitignore) are needed for the CI to pass, and the CI must pass for us to be able to merge.

@hugovkhugovk merged commit1b89591 intopython:mainFeb 11, 2024
@miss-islington-app
Copy link

Thanks@smontanaro for the PR, and@hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@smontanaro and@hugovk, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 1b895914742d20ccebd1b56b1b0936b7e00eb95e 3.12

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestFeb 11, 2024
(cherry picked from commit1b89591)Co-authored-by: Skip Montanaro <skip.montanaro@gmail.com>Co-authored-by: AN Long <aisk@users.noreply.github.com>
@bedevere-app
Copy link

GH-115284 is a backport of this pull request to the3.11 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.11only security fixes labelFeb 11, 2024
hugovk pushed a commit that referenced this pull requestFeb 11, 2024
gh-101100: Fix dangling refs in bdb.rst (GH-114983)(cherry picked from commit1b89591)Co-authored-by: Skip Montanaro <skip.montanaro@gmail.com>Co-authored-by: AN Long <aisk@users.noreply.github.com>
smontanaro added a commit to smontanaro/cpython that referenced this pull requestFeb 11, 2024
Co-authored-by: AN Long <aisk@users.noreply.github.com>(cherry picked from commit1b89591)
@smontanaro
Copy link
ContributorAuthor

Cherries have been picked. Ithink I finally created the pull request against the correct branch (3.12). Given the standardized naming of the backport branch, it does seem peculiar that GitHub can't default to the relevant branch though...

hugovk reacted with rocket emoji

@bedevere-app
Copy link

GH-115297 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelFeb 11, 2024
@AlexWaygood
Copy link
Member

Cherries have been picked. Ithink I finally created the pull request against the correct branch (3.12). Given the standardized naming of the backport branch, it does seem peculiar that GitHub can't default to the relevant branch though...

Looks great! There was just one thing missing: a backport PR to the 3.12 branch has to have a PR title starting with[3.12] in order for bedevere to recognise it as a PR backporting this PR. I changed the title for you on#115297 :)

hugovk pushed a commit that referenced this pull requestFeb 11, 2024
Co-authored-by: AN Long <aisk@users.noreply.github.com>Fix dangling refs in bdb.rst (#114983)
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull requestFeb 14, 2024
Co-authored-by: AN Long <aisk@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@aiskaiskaisk left review comments

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

Assignees

@hugovkhugovk

Labels
docsDocumentation in the Doc dirskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@smontanaro@hugovk@AlexWaygood@aisk@serhiy-storchaka
[8]ページ先頭
©2009-2025 Movatter.jp