Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-101100: Fixload_module ref#114982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
smontanaro wants to merge2 commits intopython:mainfromsmontanaro:patch-1
Closed

Conversation

smontanaro
Copy link
Contributor

@smontanarosmontanaro commentedFeb 4, 2024
edited by github-actionsbot
Loading

Text describes a user-provided method, perhaps only described in detail inPEP 302.


📚 Documentation preview 📚:https://cpython-previews--114982.org.readthedocs.build/

Text describes a user-provided method, perhaps only described in detail in `PEP 302`.
@AlexWaygood
Copy link
Member

AlexWaygood commentedFeb 4, 2024
edited
Loading

As I stated in#114729 (comment), this method is described in detail athttps://docs.python.org/3/library/importlib.html#importlib.abc.Loader.load_module. But I don't think either suppressing this link or linking tohttps://docs.python.org/3/library/importlib.html#importlib.abc.Loader.load_module would be the correct way to resolve this reference warning. This glossary entry appears pretty out of date to me;load_module is a deprecated method, that probably shouldn't be mentioned in this glossary entry at all. We should fix the warning by making the entry up-to-date

serhiy-storchaka reacted with thumbs up emoji

@smontanaro
Copy link
ContributorAuthor

The discussion aroundload_module seems familiar (@AlexWaygood?). I added a reference to the method.

@AlexWaygood
Copy link
Member

AlexWaygood commentedFeb 8, 2024
edited
Loading

The discussion aroundload_module seems familiar (@AlexWaygood?). I added a reference to the method.

Yes, we already had this conversation in#114729 (comment). And I still think the best way to correct this reference warning is to update the glossary entry so that it no longer refers to a deprecated method at all.

If that requires an importlib expert, then we should wait for an importlib expert to take a look.

@smontanaro
Copy link
ContributorAuthor

I will let@AlexWaygood and@serhiy-storchaka sort this out. Let me know your collective decision and I'll change the ref to suit so we can close out this PR.

@serhiy-storchaka
Copy link
Member

I agree that it is better to not refer to the deprecated method. But this requires the larger change that simply adding the exclamation mark.

So this Sphinx warnings serves as a reminder to rewrite the docs.

AlexWaygood reacted with thumbs up emoji

@AlexWaygood
Copy link
Member

I agree that it is better to not refer to the deprecated method. But this requires the larger change that simply adding the exclamation mark.

So this Sphinx warnings serves as a reminder to rewrite the docs.

Exactly. I would prefer that we leave this Sphinx warning unfixed for now, until we are able to fix it properly, by updating the entry so that it no longer refers to a deprecated method. I said this in#114729 (comment) and#114982 (comment)

serhiy-storchaka reacted with thumbs up emoji

@smontanaro
Copy link
ContributorAuthor

Closing. Will let others decide how best to correct this.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka left review comments

Assignees
No one assigned
Labels
awaiting reviewdocsDocumentation in the Doc dirskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@smontanaro@AlexWaygood@serhiy-storchaka

[8]ページ先頭

©2009-2025 Movatter.jp