Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-101100: Fixload_module
ref#114982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Text describes a user-provided method, perhaps only described in detail in `PEP 302`.
AlexWaygood commentedFeb 4, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
As I stated in#114729 (comment), this method is described in detail athttps://docs.python.org/3/library/importlib.html#importlib.abc.Loader.load_module. But I don't think either suppressing this link or linking tohttps://docs.python.org/3/library/importlib.html#importlib.abc.Loader.load_module would be the correct way to resolve this reference warning. This glossary entry appears pretty out of date to me; |
Uh oh!
There was an error while loading.Please reload this page.
The discussion around |
AlexWaygood commentedFeb 8, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Yes, we already had this conversation in#114729 (comment). And I still think the best way to correct this reference warning is to update the glossary entry so that it no longer refers to a deprecated method at all. If that requires an importlib expert, then we should wait for an importlib expert to take a look. |
I will let@AlexWaygood and@serhiy-storchaka sort this out. Let me know your collective decision and I'll change the ref to suit so we can close out this PR. |
I agree that it is better to not refer to the deprecated method. But this requires the larger change that simply adding the exclamation mark. So this Sphinx warnings serves as a reminder to rewrite the docs. |
Exactly. I would prefer that we leave this Sphinx warning unfixed for now, until we are able to fix it properly, by updating the entry so that it no longer refers to a deprecated method. I said this in#114729 (comment) and#114982 (comment) |
Closing. Will let others decide how best to correct this. |
Uh oh!
There was an error while loading.Please reload this page.
Text describes a user-provided method, perhaps only described in detail in
PEP 302
.📚 Documentation preview 📚:https://cpython-previews--114982.org.readthedocs.build/