Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-101100: Fix extending.rst#114981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
smontanaro wants to merge0 commits intopython:mainfromsmontanaro:main
Closed

Conversation

smontanaro
Copy link
Contributor

@smontanarosmontanaro commentedFeb 4, 2024
edited by github-actionsbot
Loading

@smontanaro
Copy link
ContributorAuthor

I did nothing. Why does it think I did something?@hugovk or@AlexWaygood can you explain?

@AlexWaygood
Copy link
Member

It looks like you made this PR directly from yourmain branch. That's generally a bad idea — it can cause strange things like this to happen :)

I suggest always making a new branch for each PR you create on github

@smontanaro
Copy link
ContributorAuthor

What I've been doing with these small edits is to edit the file onpython/cpython in GitHub. I guess I accidentally edited this one onsmontanaro/cpython.

I find the whole manually create a new branch for each little change to be annoying, so for these small edits I've resorted to editing through the GitHub web interface. (I actually edit locally, remakehtml orhtmllive, then check the result and paste the edited file into the web interface.)

AlexWaygood reacted with thumbs up emoji

@AlexWaygood
Copy link
Member

Specifically, it looks like you might have force-pushed to themain branch of your CPython clone to get it in sync with CPython'smain branch. That then meant that there were 0 changes between yourmain branch and CPython'smain branch; so, since this is a PR asking for changes from yourmain branch to be merged into CPython'smain branch, github automatically closed the PR.

@smontanaro
Copy link
ContributorAuthor

Okay, I can buy that. I do remember accidentally committing some small doc change, then later issuing agit revert command.

AlexWaygood reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting reviewdocsDocumentation in the Doc dirskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@smontanaro@AlexWaygood

[8]ページ先頭

©2009-2025 Movatter.jp