Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-101100: Fix dangling references in pickle.rst#114972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AlexWaygood merged 3 commits intopython:mainfromsmontanaro:patch-10
Feb 4, 2024

Conversation

smontanaro
Copy link
Contributor

@smontanarosmontanaro commentedFeb 3, 2024•
edited by github-actionsbot
Loading

Fairly straightforward. Oddly enough, I found no canonical definition ofappend orextend methods, so I just. suppressed those links.

📚 Documentation preview 📚:https://cpython-previews--114972.org.readthedocs.build/

Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good! Two small suggestions:

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, looks great! However, I'm unable to merge this PR (the "merge" button is physically unavailable to me right now 🙂) until the CI failure is fixed as part of this PR:

Congratulations! You improved:

Doc/library/pickle.rst

Please remove from Doc/tools/.nitignore

Error: Process completed with exit code 255.

Could you remove that line fromDoc/tools/.nitignore?

@smontanaro
Copy link
ContributorAuthor

Could you remove that line fromDoc/tools/.nitignore?

Should be good to go.

@AlexWaygood
Copy link
Member

Thanks!

@AlexWaygoodAlexWaygood merged commitec69e1d intopython:mainFeb 4, 2024
@AlexWaygoodAlexWaygood added needs backport to 3.11only security fixes needs backport to 3.12only security fixes labelsFeb 4, 2024
@miss-islington-app
Copy link

Thanks@smontanaro for the PR, and@AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks@smontanaro for the PR, and@AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestFeb 4, 2024
(cherry picked from commitec69e1d)Co-authored-by: Skip Montanaro <skip.montanaro@gmail.com>Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@miss-islington-app
Copy link

Sorry,@smontanaro and@AlexWaygood, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker ec69e1d0ddc9906e0fb755a5234aeabdc96450ab 3.12

@bedevere-app
Copy link

GH-114992 is a backport of this pull request to the3.11 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.11only security fixes labelFeb 4, 2024
@smontanarosmontanaro deleted the patch-10 branchFebruary 4, 2024 14:26
AlexWaygood added a commit that referenced this pull requestFeb 4, 2024
…114992)gh-101100: Fix dangling references in pickle.rst (GH-114972)(cherry picked from commitec69e1d)Co-authored-by: Skip Montanaro <skip.montanaro@gmail.com>Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
smontanaro added a commit to smontanaro/cpython that referenced this pull requestFeb 4, 2024
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>(cherry picked from commitec69e1d)
@bedevere-app
Copy link

GH-114999 is a backport of this pull request to the3.11 branch.

@bedevere-app
Copy link

GH-114999 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelFeb 4, 2024
AlexWaygood added a commit that referenced this pull requestFeb 4, 2024
…14999)gh-101100: Fix dangling references in pickle.rst (#114972)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>(cherry picked from commitec69e1d)
aisk pushed a commit to aisk/cpython that referenced this pull requestFeb 11, 2024
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull requestFeb 14, 2024
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees

@AlexWaygoodAlexWaygood

Labels
docsDocumentation in the Doc dirskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@smontanaro@AlexWaygood
[8]ページ先頭
©2009-2025 Movatter.jp