Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-101100: Fix sphinx warnings inhowto/logging.rst#114846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| For versions of Python prior to 3.2, the behaviour is as follows: | ||
| The event is output using a 'handler of last resort', stored in | ||
| :data:`lastResort`. This internal handler is not associated with any |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lastResort,raiseExceptions etc. are module-level attributes - how come we don't use the:attr: role for them? Is my understanding of that role outdated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We usedata with module level variables to define:https://www.sphinx-doc.org/en/master/usage/domains/python.html#directive-py-data and reference them:https://www.sphinx-doc.org/en/master/usage/domains/python.html#role-py-data :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for updating my knowledge.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sorry,@sobolevn and@hugovk, I could not cleanly backport this to |
GH-114872 is a backport of this pull request to the3.11 branch. |
Thanks! 🧹📖 |
GH-114878 is a backport of this pull request to the3.12 branch. |
…ythonGH-114846)(cherry picked from commitdc01b91)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
…) (#114878)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
…14846)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Uh oh!
There was an error while loading.Please reload this page.
Before:
Changes:
.. versionchangedin one placeraiseExceptionsdoc, using its docstring fromlogging/__init__.py📚 Documentation preview 📚:https://cpython-previews--114846.org.readthedocs.build/