Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-114271: Fix race inThread.join()#114839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pitrou merged 34 commits intopython:mainfrommpage:gh-114271-remove-tstate_lock
Mar 16, 2024
Merged
Show file tree
Hide file tree
Changes from1 commit
Commits
Show all changes
34 commits
Select commitHold shift + click to select a range
fb13cf6
Fix race in `Thread.join()`
mpageJan 26, 2024
b093e5d
📜🤖 Added by blurb_it.
blurb-it[bot]Feb 1, 2024
1039208
Fix NEWS entry
mpageFeb 1, 2024
196081d
Work around c-analyzer limitation
mpageFeb 5, 2024
19d7af1
Merge branch 'main' into gh-114271-remove-tstate_lock
mpageFeb 5, 2024
c86d349
Merge branch 'main' into gh-114271-remove-tstate_lock
mpageFeb 7, 2024
40e4b36
Merge branch 'main' into gh-114271-remove-tstate_lock
mpageFeb 14, 2024
4ed1083
Merge branch 'main' into gh-114271-remove-tstate_lock
mpageFeb 14, 2024
34b6065
Merge branch 'main' into gh-114271-remove-tstate_lock
mpageMar 1, 2024
1c82786
Fix two compilation errors post merge
mpageMar 1, 2024
0e86cf9
Use ThreadHandle as the single abstraction for thread joining
mpageMar 2, 2024
76bde03
Isolate all logic in _threadmodule
mpageMar 4, 2024
02123b8
Fix flag
mpageMar 5, 2024
24c1d47
Note that the once flag serializes both join and set_done
mpageMar 6, 2024
1a1bfde
Fix unused variable warning
mpageMar 6, 2024
b3c2c45
Rename ThreadHandleObject to PyThreadHandleObject
mpageMar 6, 2024
7b9d007
Be consistent with documentation of true values
mpageMar 6, 2024
5d0dc7a
Threads started using `start_joinable_thread` should be daemon thread…
mpageMar 6, 2024
11bb826
Remove any remaining handles once the module is cleared
mpageMar 7, 2024
06f6787
Always have a _ThreadHandle in Thread
mpageMar 8, 2024
d56f892
Check main thread handle during shutdown
mpageMar 8, 2024
57e106d
Merge branch 'main' into gh-114271-remove-tstate_lock
mpageMar 8, 2024
2218c0a
Remove vestigial _PyEventRc declarations
mpageMar 8, 2024
f9d3290
Remove duplicate declaration
mpageMar 8, 2024
a7095e4
Revert order change in `_DummyThread.is_alive`
mpageMar 8, 2024
ccd1c2e
Merge branch 'main' into gh-114271-remove-tstate_lock
mpageMar 11, 2024
180300c
Add handles to shutdown list before starting the thread
mpageMar 11, 2024
c486503
Move some code around to remove need for forward decls
mpageMar 12, 2024
3121623
Simplify start failure path
mpageMar 12, 2024
ee96259
Merge branch 'main' into gh-114271-remove-tstate_lock
mpageMar 15, 2024
dc57ed2
Use infinitive in docstring for _shutdown
mpageMar 15, 2024
48b86ae
Update comment for _make_thread_handle
mpageMar 15, 2024
9a8ea9b
Merge branch 'main' into gh-114271-remove-tstate_lock
pitrouMar 16, 2024
339b2e6
Merge branch 'main' into gh-114271-remove-tstate_lock
pitrouMar 16, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
Fix two compilation errors post merge
  • Loading branch information
@mpage
mpage committedMar 1, 2024
commit1c82786c20e2b4e9ba7c2f25bfb3f7d2d5954dbc
2 changes: 1 addition & 1 deletionModules/_threadmodule.c
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -119,7 +119,7 @@ event_wait(PyEventObject *self, PyObject *args)
return NULL;
}

_PyTime_t timeout_ns = -1;
PyTime_t timeout_ns = -1;
if (timeout_obj && timeout_obj != Py_None) {
int err = _PyTime_FromSecondsObject(&timeout_ns, timeout_obj,
_PyTime_ROUND_TIMEOUT);
Expand Down
7 changes: 0 additions & 7 deletionsPython/lock.c
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -274,13 +274,6 @@ _PyEvent_Notify(PyEvent *evt)
}
}

int
_PyEvent_IsSet(PyEvent *evt)
{
uint8_t v = _Py_atomic_load_uint8(&evt->v);
return v == _Py_LOCKED;
}

void
PyEvent_Wait(PyEvent *evt)
{
Expand Down

[8]ページ先頭

©2009-2025 Movatter.jp