Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-114763: Protect lazy loading modules from attribute access race#114781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
12 commits Select commitHold shift + click to select a range
d57f4eb gh-114763: Protect lazy loading modules from attribute access race
effigies3db717c TEST: Reproduce gh-114763
effigies5424d0c Add new blurb
effigies96c08c5 Improve comments around the branching
effigies3642ddc TEST: Use TestCase.assert* methods
effigies46238e5 Merge branch 'main' into fix-issue-114763
brettcannon6accf0c Apply suggestions from code review
effigiesbb2292f TEST: Require working threading for test_module_load_race
effigies57fe084 Move threading import to module level of importlib.util
effigies40383a0 Make is_loading a bool instead of Event
effigies6322dd6 Merge branch 'main' into fix-issue-114763
effigies023d65d Merge branch 'main' into fix-issue-114763
brettcannonFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
PrevPrevious commit
Merge branch 'main' into fix-issue-114763
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit023d65dc52cfcb035586e9294867124691137f41
There are no files selected for viewing
This merge commit was added into this branch cleanly.
There are no new changes to show, but you can stillview the diff.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.