Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-114713: handle case of an empty string passed to ZoneInfo#114731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Eclips4 merged 8 commits intopython:mainfromwrongnull:empy-key-zoneinfo
Apr 15, 2025

Conversation

wrongnull
Copy link
Contributor

@wrongnullwrongnull commentedJan 29, 2024•
edited by bedevere-appbot
Loading

This special case will make the error message less confusing.

@Eclips4
Copy link
Member

Eclips4 commentedJan 29, 2024•
edited
Loading

I don't think that kind of change is needed in aNEWS entry. By other hand this change is user visible, so adding aNEWS entry probably makes sense.

Also, macOS CI/CD failure is unrelated. I'll restart it later.

wrongnull reacted with thumbs up emoji

Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think it makes sense to check for an empty string beforeif os.path.isabs(path):, isn't it?

Eclips4 reacted with thumbs up emoji
@wrongnull
Copy link
ContributorAuthor

Thank you@sobolevn for the review. I agree with your statements so I rewrote the check

@serhiy-storchakaserhiy-storchaka added needs backport to 3.13bugs and security fixes and removed needs backport to 3.11only security fixes labelsMay 9, 2024
Copy link
Member

@Eclips4Eclips4 left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you, LGTM.
Though I think that a short NEWS entry would be good here.

@StanFromIreland
Copy link
Member

@wrongnull do you have a moment to add a NEWS entry?

@wrongnull
Copy link
ContributorAuthor

@wrongnull do you have a moment to add a NEWS entry?

yeah, I'm going to add it now

StanFromIreland reacted with thumbs up emoji

…kq9vZ.rstCo-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@tomasr8tomasr8 removed the needs backport to 3.12only security fixes labelApr 10, 2025
@StanFromIreland
Copy link
Member

@Eclips4 friendly ping :-)

@Eclips4Eclips4enabled auto-merge (squash)April 15, 2025 18:23
@Eclips4Eclips4 merged commit884df11 intopython:mainApr 15, 2025
39 checks passed
@miss-islington-app
Copy link

Thanks@wrongnull for the PR, and@Eclips4 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestApr 15, 2025
…oneInfo` (pythonGH-114731)(cherry picked from commit884df11)Co-authored-by: Bogdan Romanyuk <65823030+wrongnull@users.noreply.github.com>Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
@bedevere-app
Copy link

GH-132563 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelApr 15, 2025
Eclips4 added a commit that referenced this pull requestApr 15, 2025
…ZoneInfo` (GH-114731) (#132563)gh-114713: Handle case of an empty string passed to `zoneinfo.ZoneInfo` (GH-114731)(cherry picked from commit884df11)Co-authored-by: Bogdan Romanyuk <65823030+wrongnull@users.noreply.github.com>Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
Eclips4 added a commit to Eclips4/cpython that referenced this pull requestMay 3, 2025
Eclips4 added a commit that referenced this pull requestMay 3, 2025
Revert "gh-114713: Handle case of an empty string passed to `zoneinfo.ZoneInfo` (#114731)"This reverts commit884df11.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 3, 2025
Revert "pythongh-114713: Handle case of an empty string passed to `zoneinfo.ZoneInfo` (pythonGH-114731)"This reverts commit884df11.(cherry picked from commitfe44fc4)Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
Eclips4 added a commit that referenced this pull requestMay 3, 2025
gh-114713: Revertgh-114731 (GH-133330)Revert "gh-114713: Handle case of an empty string passed to `zoneinfo.ZoneInfo` (GH-114731)"This reverts commit884df11.(cherry picked from commitfe44fc4)Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@Eclips4Eclips4Eclips4 approved these changes

@StanFromIrelandStanFromIrelandStanFromIreland left review comments

@pgansslepganssleAwaiting requested review from pganssle

@sobolevnsobolevnAwaiting requested review from sobolevn

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@wrongnull@Eclips4@StanFromIreland@sobolevn@serhiy-storchaka@tomasr8
[8]ページ先頭
©2009-2025 Movatter.jp