Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-101100: Fix sphinx warnings inlibrary/enum.rst#114696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 2 commits intopython:mainfromsobolevn:issue-101100-lib-enum
Feb 9, 2024

Conversation

sobolevn
Copy link
Member

@sobolevnsobolevn commentedJan 29, 2024•
edited by github-actionsbot
Loading

Before:

/Users/sobolev/Desktop/cpython2/Doc/library/enum.rst:798: WARNING: py:attr reference target not found: Enum._name_/Users/sobolev/Desktop/cpython2/Doc/library/enum.rst:799: WARNING: py:attr reference target not found: Enum._value_/Users/sobolev/Desktop/cpython2/Doc/library/enum.rst:805: WARNING: py:attr reference target not found: Enum._order_

It renders just fine:
Снимок экрана 2024-01-29 в 09 34 09

I though that I can possibly define these attributes in-place, but their rendering would be very strange this way. So, I went with a little duplication.

📚 Documentation preview 📚:https://cpython-previews--114696.org.readthedocs.build/

@hugovk
Copy link
Member

Technically looks okay, but let's check with@ethanfurman: if the whole point of_order_ is for Python 2/3 consistency, do we need to keep that detail in the docs?

Copy link
Member

@ethanfurmanethanfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A minor change, then good to go!

hugovk reacted with thumbs up emoji
@bedevere-app
Copy link

When you're done making the requested changes, leave the comment:I have made the requested changes; please review again.

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
@hugovkhugovk merged commit553c90c intopython:mainFeb 9, 2024
@miss-islington-app
Copy link

Thanks@sobolevn for the PR, and@hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@sobolevn and@hugovk, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 553c90ccc2f5b15be76a2bb6e38d23e58d739e2f 3.12

@miss-islington-app
Copy link

Sorry,@sobolevn and@hugovk, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker 553c90ccc2f5b15be76a2bb6e38d23e58d739e2f 3.11

@sobolevn
Copy link
MemberAuthor

I will send backports PRs later 👍

hugovk reacted with thumbs up emoji

@bedevere-app
Copy link

GH-115208 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelFeb 9, 2024
sobolevn added a commit to sobolevn/cpython that referenced this pull requestFeb 9, 2024
@bedevere-app
Copy link

GH-115209 is a backport of this pull request to the3.11 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.11only security fixes labelFeb 9, 2024
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull requestFeb 14, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ethanfurmanethanfurmanethanfurman approved these changes

@hugovkhugovkAwaiting requested review from hugovkhugovk is a code owner

Assignees

@hugovkhugovk

Labels
docsDocumentation in the Doc dirskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@sobolevn@hugovk@ethanfurman
[8]ページ先頭
©2009-2025 Movatter.jp